Initially fill the membership application form based on donation data
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

None

Authored By

	kai.nissen
	Dec 5 2017, 4:18 PM

Description

If coming from a donation confirmation page the form should be filled with the data we already stored for the donation case.

Address data
Bank account data, if provided during the donation process
if no data is present or data is present partially (e. g. purged, anonymous) fields should not contain a value and behave as if not filled out
data regarding address type and payment type should also be preselected
tracking data (campaign/keyword) is stored for each membership application
the membership type is preselected to be sustaining (see T181982) - provided via deep link T181819

Background:

the data is fetched using a donation ID and a valid access token

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T177929 Integrate new layout
Resolved	None	T177933 become member - Integrate new layout
Duplicate	None	T182087 Integrate membership call-to-action on donation confirmation page
Resolved	None	T182121 Initially fill the membership application form based on donation data
Resolved	None	T181819 Change layout of the donation confirmation pages

Event Timeline

kai.nissen created this task.Dec 5 2017, 4:18 PM

kai.nissen updated the task description. (Show Details)Dec 6 2017, 2:40 PM

kai.nissen set the point value for this task to 8.

kai.nissen moved this task from Backlog to Ready on the WMDE-Fundraising-Funban-2 board.

• Pablo-WMDE mentioned this in T177933: become member - Integrate new layout.Dec 7 2017, 8:06 AM

kai.nissen added a subtask: T181819: Change layout of the donation confirmation pages.Dec 7 2017, 10:40 AM

• Pablo-WMDE claimed this task.Dec 8 2017, 4:36 PM

• Pablo-WMDE moved this task from Ready to Doing on the WMDE-Fundraising-Funban-2 board.

PR https://github.com/wmde/FundraisingFrontend/pull/1092

• Pablo-WMDE removed • Pablo-WMDE as the assignee of this task.Dec 12 2017, 5:17 PM

• Pablo-WMDE moved this task from Doing to Review on the WMDE-Fundraising-Funban-2 board.

@gabriel-wmde you mentioned you'd like to see a change to the behavior that as soon as the debit payment type is selected, the section info (on the right) shows an error state - because bank data is not provided.
This behavior is consistent between donation and membership (when creating a membership from a donation).
Before tackling this I believe it's important to know the target state and to fix the cause (AJAX validation is run and comes back negative) accordingly, not the symptoms.

@kai.nissen
When chosing debit as payment type, should section info

remain "grey"
only turn "red" if the bank data is invalid while actually provided
only turn "black" if the bank data is provided and valid

When chosing any other payment type (not requiring bank data) the section info should consequently

be "grey" while no payment type is chosen
only turn "black" if the payment type is chosen
a "red" state can not be reached by payment types other than debit

Waiting for T181819 to call this "ready to test" as this provides the deep links on the donation confirmation test - so far this could only be user tested by hackers.

Created T182963 to address payment type section info.
Created T182966 to clean up routes.php changes
Created T182967 to improve the way membership initial state is set from server side