Page MenuHomePhabricator

dispatchChanges.php still being run from the Wikidata build
Closed, ResolvedPublic

Description

Steps to reproduce:

ladsgroup@terbium:~$ mwscript extensions/Wikidata/extensions/Wikibase/repo/maintenance/dispatchChanges.php --wiki testwikidatawiki --max-time 900 --batch-size 200 --dispatch-interval 30
PHP Fatal error:  Call to undefined method Wikibase\Repo\Store\Sql\LockManagerSqlChangeDispatchCoordinator::setLockGraceInterval() in /srv/mediawiki/php-1.31.0-wmf.11/extensions/Wikidata/extensions/Wikibase/repo/maintenance/dispatchChanges.php on line 176
Fatal error: Call to undefined method Wikibase\Repo\Store\Sql\LockManagerSqlChangeDispatchCoordinator::setLockGraceInterval() in /srv/mediawiki/php-1.31.0-wmf.11/extensions/Wikidata/extensions/Wikibase/repo/maintenance/dispatchChanges.php on line 176

Event Timeline

The dispatcher failure is very worrying, probably blocker of the deployment. ping @Lydia_Pintscher @greg @Joe (it might be the cause)

So a cronjob needs to be updated? The script will of course fail to run, because the autoloader is no longer setup.

Oh, that was so stupid of me. Yes. I get that fixed in a sec

Change 395672 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/puppet@production] Make wikidata cronjobs use the Wikibase extension and not the build

https://gerrit.wikimedia.org/r/395672

Change 395672 merged by Dzahn:
[operations/puppet@production] Make wikidata cronjobs use the Wikibase extension and not the build

https://gerrit.wikimedia.org/r/395672

cronjobs have been updated on terbium and confirmed there are no remnants, just the 3 updated commands. no crons on wasat

Puppet! The one thing I didn't hunt through while killing the build!

Addshore renamed this task from The build is being used by testwikidatawiki to dispatchChanges.php still being run from the Wikidata build.Dec 6 2017, 8:25 AM
Addshore triaged this task as Unbreak Now! priority.Dec 6 2017, 8:27 AM

This also needs to be changed for the live site.

https://phabricator.wikimedia.org/source/operations-puppet/browse/production/modules/mediawiki/manifests/maintenance/wikidata.pp;4478e10716df2698fa925e9892c4598fe4e06aa5$15

Marking as UBN as otherwise this will (likely) imminently explode..

Change 395699 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/puppet@production] Make wikidatawiki cronjobs use the Wikibase extension and not the build

https://gerrit.wikimedia.org/r/395699

Change 395699 merged by Dzahn:
[operations/puppet@production] Make wikidatawiki cronjobs use the Wikibase extension and not the build

https://gerrit.wikimedia.org/r/395699

applied on terbium

[terbium:~] $ sudo crontab -u www-data -l | grep wikidata
0,15,30,45 * * * * /usr/local/bin/mwscript extensions/Wikibase/repo/maintenance/pruneChanges.php --wiki wikidatawiki --number-of-days=3 >> /var/log/wikidata/prune2.log 2>&1
*/15 * * * * /usr/local/bin/mwscript extensions/Wikibase/repo/maintenance/dispatchChanges.php --wiki testwikidatawiki --max-time 900 --batch-size 200 --dispatch-interval 30 >/dev/null 2>&1
0,15,30,45 * * * * /usr/local/bin/mwscript extensions/Wikibase/repo/maintenance/pruneChanges.php --wiki testwikidatawiki --number-of-days=3 >> /var/log/wikidata/prune-testwikidata.log 2>&1
*/3 * * * * echo "$$: Starting dispatcher" >> /var/log/wikidata/dispatchChanges-wikidatawiki.log; /usr/local/bin/mwscript extensions/Wikibase/repo/maintenance/dispatchChanges.php --wiki wikidatawiki --max-time 540 --batch-size 420 --dispatch-interval 25 --randomness 15 >> /var/log/wikidata/dispatchChanges-wikidatawiki.log 2>&1; echo "$$: Dispatcher exited with $?" >> /var/log/wikidata/dispatchChanges-wikidatawiki.log
[terbium:~] $