Description
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/Wikispeech | master | +4 K -4 K | Refactor Javascript modules |
Related Objects
- Mentioned In
- T174799: failed stubbing in tests.
T149302: Improve settings page
rEWIS2a69b6b577ef: Refactor Javascript modules
rEWISbbf7d28e2704: Refactor Javascript modules
rEWIS269c67192885: Refactor Javascript modules
rEWISb0057badda3c: Refactor Javascript modules
rEWIS189d03d07e2c: Refactor Javascript modules
rEWISd1a31f302d20: Refactor Javascript modules - Mentioned Here
- rEWIS81fca40dc388: Add user preferences
rEWIS2a69b6b577ef: Refactor Javascript modules
T174799: failed stubbing in tests.
T133680: [Task] Functionality: Play selected text (Wikispeech)
T149302: Improve settings page
Event Timeline
Where functions live, as of baba7b102e:
modules/ext.wikispeech.selectionPlayer.js
25:playSelectionIfValid
45:isSelectionValid
71:isTextSelected
84:getFirstNodeInSelection
125:getFirstTextNode
158:isNodeInUtterance
186:playSelection
271:getStartUtterance
316:isPointInItems
375:getNextTextNode
417:getStartToken
451:setStartTime
464:getLastNodeInSelection
506:getLastTextNode
545:getEndUtterance
583:getPreviousTextNode
625:getEndToken
664:setEndTime
679:addSelectionPlayer
710:showSelectionPlayer
744:getTextDirection
757:resetPreviousEndUtterance
modules/ext.wikispeech.highlighter.js
31:highlightUtterance
72:wrapTextNodes
117:startTokenHighlighting
133:highlightToken
180:getNodeInUtteranceHighlighting
200:setHighlightTokenTimer
235:removeWrappers
256:clearHighlightTokenTimer
modules/ext.wikispeech.js
24:enabledForNamespace
37:loadUtterances
76:addControlPanel
131:addButton
143:addStackToPlayStopButton
159:addSpanToPlayStopButton
172:addElementToPlayStopButtonStack
191:addLinkButton
212:playOrStop
227:isPlaying
235:stop
253:play
273:playUtterance
300:audioIsReady
314:addCanPlayListener
327:stopUtterance
351:skipAheadUtterance
368:getNextUtterance
384:getUtteranceByOffset
401:skipBackUtterance
434:getPreviousUtterance
445:skipAheadToken
472:getNextToken
494:getCurrentToken
531:isSilent
543:skipBackToken
570:getPreviousToken
595:getLastToken
609:addKeyboardShortcuts
670:eventMatchShortcut
693:prepareUtterance
757:loadAudio
801:requestTts
844:addTokens
897:addOffsetsAndItems
989:getStartOffsetInUtteranceString
modules/ext.wikispeech.util.js
22:getNodeForItem
46:getLast
First draft of proposed structure:
== ext.wikispeech.main == <-- start point enabledForNamespace == ext.wikispeech.ui == addControlPanel addButton addStackToPlayStopButton addSpanToPlayStopButton addElementToPlayStopButtonStack addLinkButton addCanPlayListener addKeyboardShortcuts eventMatchShortcut addSelectionPlayer showSelectionPlayer getTextDirection == ext.wikispeech.player == playOrStop isPlaying stop play playUtterance audioIsReady stopUtterance skipAheadUtterance skipBackUtterance skipAheadToken skipBackToken == ext.wikispeech.selectionPlayer == playSelectionIfValid isSelectionValid isTextSelected getFirstNodeInSelection playSelection setStartTime getLastNodeInSelection setEndTime resetPreviousEndUtterance == ext.wikispeech.storage == <--not too happy about this name loadUtterances prepareUtterance loadAudio requestTts addTokens addOffsetsAndItems getStartOffsetInUtteranceString getNextUtterance getUtteranceByOffset getNextToken getCurrentToken isSilent getPreviousToken getLastToken getPreviousUtterance getFirstTextNode isNodeInUtterance getStartUtterance isPointInItems getNextTextNode getStartToken getLastTextNode getEndUtterance getPreviousTextNode getEndToken == ext.wikispeech.highlighter == highlightUtterance wrapTextNodes startTokenHighlighting highlightToken getNodeInUtteranceHighlighting setHighlightTokenTimer removeWrappers clearHighlightTokenTimer == ext.wikispeech.util == getNodeForItem getLast
Change 398851 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Refactor Javascript modules
@Lokal_Profil, have you had time to take a look at the status on the patch? There are some comments, but last we spoke about it, it sounded like you hadn't looked at the whole thing.
Haven't looked at this since 2017. IIRC I looked at some of the classes but not all. That said if you are wanting to do a rebase then feel free to do that now since I'll probably have to look at it all with fresh eyes anyway
Change 398851 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Refactor Javascript modules