Page MenuHomePhabricator

Remove references to deleted $this->debug in installer
Closed, ResolvedPublic

Description

includes/installer/Installer.php has references to an old debugging
variable $this->debug (around line 697). Since this debugging system
has been removed, remove all remaining references to it.

Additionally the old debugging system was outputting exceptions in unescaped
ways, so may have been unsafe from an XSS perspective, so all the more reason
to get rid of it.

Event Timeline

Bawolff created this task.Dec 6 2017, 4:52 PM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptDec 6 2017, 4:52 PM

Change 396547 had a related patch set uploaded (by Albert221; owner: Albert221):
[mediawiki/core@master] Remove references to deleted $this->debug in installer

https://gerrit.wikimedia.org/r/396547

Bawolff closed this task as Resolved.Dec 8 2017, 11:36 PM

Change 396547 merged by jenkins-bot:
[mediawiki/core@master] Remove references to deleted $this->debug in installer

https://gerrit.wikimedia.org/r/396547