Page MenuHomePhabricator

Refactor getRandom() and inSample() methods from NavigationTiming extension, add tests
Closed, ResolvedPublic

Description

NavigationTiming could be DRYer. Also use window.crypto if available, instead of Math.random.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2017, 10:20 PM

Change 394648 had a related patch set uploaded (by Imarlier; owner: Imarlier):
[mediawiki/extensions/NavigationTiming@master] ext.NavigationTiming: Refactor Random and inSample methods

https://gerrit.wikimedia.org/r/394648

Krinkle triaged this task as Medium priority.Dec 14 2017, 8:26 PM

Change 394648 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] ext.NavigationTiming: Refactor Random and inSample methods

https://gerrit.wikimedia.org/r/394648

Krinkle closed this task as Resolved.Dec 14 2017, 8:35 PM
Krinkle removed a project: Patch-For-Review.