Refactor getRandom() and inSample() methods from NavigationTiming extension, add tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Imarlier
	Dec 6 2017, 10:20 PM

Description

NavigationTiming could be DRYer. Also use window.crypto if available, instead of Math.random.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ext.NavigationTiming: Refactor Random and inSample methods	mediawiki/extensions/NavigationTiming	master	+88 -18

Customize query in gerrit

Event Timeline

• Imarlier created this task.Dec 6 2017, 10:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2017, 10:20 PM

Change 394648 had a related patch set uploaded (by Imarlier; owner: Imarlier):
[mediawiki/extensions/NavigationTiming@master] ext.NavigationTiming: Refactor Random and inSample methods

https://gerrit.wikimedia.org/r/394648

gerritbot added a project: Patch-For-Review.Dec 6 2017, 10:21 PM

-> NavigationTiming so this can be found when searching in that basket

Krinkle triaged this task as Medium priority.Dec 14 2017, 8:26 PM

Change 394648 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] ext.NavigationTiming: Refactor Random and inSample methods

https://gerrit.wikimedia.org/r/394648

Krinkle closed this task as Resolved.Dec 14 2017, 8:35 PM

Krinkle removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 14 2017, 9:00 PM

Refactor getRandom() and inSample() methods from NavigationTiming extension, add testsClosed, ResolvedPublicActions

Description

Details

Event Timeline

Refactor getRandom() and inSample() methods from NavigationTiming extension, add tests
Closed, ResolvedPublic
Actions