Page MenuHomePhabricator

date of birth remains or changes again to dark green (unconfirmed)
Closed, InvalidPublic

Description

Description: the field for the date of birth remains or changes again to dark green (unconfirmed). And maybe the spelling/style should be given?
Browser: Chrome 62
Browser window width: 1024
Browser window height: 768
Screenshots :

date of birth field.PNG (679×992 px, 33 KB)

Event Timeline

Yes, this behaviour might be confusing. Does the missing validity indication have a technical background, because this is an optional field?

I suggest to add (Optional) to the field's label/placeholder and perform a validation to make sure, users are using the right date format.

@Jan_Dittrich any other/further suggestions?

I suggest to add (Optional) to the field's label/placeholder

Agree.

to make sure, users are using the right date format.

Agree. To ease picking the format: Do we use a date picker and/or type="date? (It landed in all major browsers now!)

Unrelated hint: With the data-optional="true" attribute introduced in https://github.com/wmde/FundraisingFrontend/pull/1152 and the data-pattern attribute the validation state of this field can be set properly, regardless of the field type.

Postponed, removing parent task.

We can't use type="date", since it is not supported by Safari and IE.

I see the following options:

  • validation using a very complex regex (which does not cover the expected format being displayed somewhere)
  • adding a JavaScript-based date picker

Displaying the expected format seems hard. The skin (mis)uses the placeholder for the field's label and I don't think, we should add the desired format there. Putting it into the error message might also not be sufficient.