Page MenuHomePhabricator

Wrong amount shown at the confirmation page - comma
Closed, ResolvedPublic

Description

Description: Wrong amount shown at the confirmation page. I primarily entered 5000.55 €. The amount after the comma has been dropped.
Browser: Chrome 62
Browser window width: 1024
Browser window height: 768
Screenshots :

Wrong amount at confirmation page 1.PNG (467×966 px, 34 KB)
and
Wrong amount at confirmation page 2.PNG (399×326 px, 9 KB)

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone
ResolvedNone

Event Timeline

The membership_fee field in the database is of type INT(11), which means the decimal amount will be silently dropped. Since changing the amount type might have also effects on the export, I'd say we postpone the feature "allow decimal membership fees" (or ditch it) and adapt the UI for the time being, meaning disallowing decimal points. Do you agree, @kai.nissen?

kai.nissen moved this task from Backlog to Ready on the WMDE-Fundraising-Funban-2 board.

I suspect the export dumping the amount as an integer as well. I do agree to disallow decimal points (and I don't think, we should add this feature at all).

I do agree to disallow decimal points (and I don't think, we should add this feature at all).

Yes. It it is OK to not make it possible to give non-integers if it rejects them right when people do the input (so it does not take . or , )