Page MenuHomePhabricator

VisualEditor cssUrlEmbed:dist complains not being able to find resize-nw-se.svg and resize-ne-sw.svg
Closed, ResolvedPublic

Description

While running npm install on VisualEditor/VisualEditor I have spotted:

Running "cssUrlEmbed:dist" (cssUrlEmbed) task

function bold() { [native code] }
6 embeddable URLs found
>> "../../../ui/styles/images/resize-nw-se.svg" not found on disk
>> "../../../ui/styles/images/resize-ne-sw.svg" not found on disk

function bold() { [native code] }
6 embeddable URLs found
>> "../../../ui/styles/images/resize-nw-se.svg" not found on disk
>> "../../../ui/styles/images/resize-ne-sw.svg" not found on disk

function bold() { [native code] }
6 embeddable URLs found
>> "../../../ui/styles/images/resize-nw-se.svg" not found on disk
>> "../../../ui/styles/images/resize-ne-sw.svg" not found on disk

function bold() { [native code] }
6 embeddable URLs found
>> "../../../ui/styles/images/resize-nw-se.svg" not found on disk
>> "../../../ui/styles/images/resize-ne-sw.svg" not found on disk

That show up in the CI console log as well. Not sure why cssUrlEmbed:dist does not cause the installation to be aborted though.

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterUpdate VE core submodule to master (cf99ae2e0)
VisualEditor/VisualEditor : masterFix missing resize handles in dist

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2017, 12:07 PM

Change 519226 had a related patch set uploaded (by Jforrester; owner: Esanders):
[VisualEditor/VisualEditor@master] Fix missing resize handles in dist

https://gerrit.wikimedia.org/r/519226

Change 519226 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix missing resize handles in dist

https://gerrit.wikimedia.org/r/519226

Jdforrester-WMF closed this task as Resolved.Jun 26 2019, 7:33 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 26 2019, 7:33 PM

Change 519290 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cf99ae2e0)

https://gerrit.wikimedia.org/r/519290

Change 519290 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cf99ae2e0)

https://gerrit.wikimedia.org/r/519290

And it did not fail because of:

		cssUrlEmbed: {
			options: {
				// TODO: A few image paths aren't relative to src/ui/styles
				failOnMissingUrl: false,

Thank you for the fix :-]

We didn't actually fix the root problem, but because we upstreamed all of our icons to OOUI we were left with custom images in just one folder. If we try to add images anywhere else we'll run into this problem again.

Though my understand is that by removing the failOnMissingUrl: false parameter, cssUrlEmbed:dist would now fail and thus highlight the issue. So that sounds well covered to me now :]