Page MenuHomePhabricator
Create Task
Maniphest T182318

New filters for edit review on Watchlist can't be opt-out on wikis
Closed, ResolvedPublic
Actions

Description

Filters are available by default on Watchlist. Whether you have the filters on Watchlist is supposed to be controlled by the Beta preferences. I've tried to change my preferences using my WMF account and my volunteer account on Wikidata with no change, apparently. @Lea_Lacroix_WMDE tried it as well with no success.

I have that issue on deployment train phase 0 and phase 1 wikis (mediawiki.org, all non Wikipedias, Wikidata, Catalan Wikipedia)
On phase 2 wikis (fr.wp, es.wp), I've been able to enable and disable the Betafeature.

Opt-out the Recent Changes improvements in preferences turns the Watchlist to the default state (no filters).

Details

SubjectRepoBranchLines +/-
WLFilters: Correctly check if RCFilters should be enabled on WLmediawiki/corewmf/1.31.0-wmf.11+1 -1
WLFilters: Correctly check if RCFilters should be enabled on WLmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Trizek-WMF created this task.Dec 7 2017, 1:08 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 7 2017, 1:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Trizek-WMF triaged this task as Unbreak Now! priority.Dec 7 2017, 1:09 PM
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptDec 7 2017, 1:09 PM
Trizek-WMF updated the task description. (Show Details)Dec 7 2017, 1:10 PM
Trizek-WMF updated the task description. (Show Details)Dec 7 2017, 1:18 PM
gerritbot subscribed.Dec 7 2017, 1:30 PM

Change 396003 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] WLFilters: Correctly check if RCFilters should be enabled on WL

https://gerrit.wikimedia.org/r/396003

gerritbot added a project: Patch-For-Review.Dec 7 2017, 1:30 PM
SBisson claimed this task.Dec 7 2017, 1:31 PM
SBisson edited projects, added Collaboration-Team-Triage (Collab-Team-Next-Quarter); removed Collaboration-Team-Triage.
SBisson edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Next-Quarter).
SBisson moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
SBisson merged a task: T182272: [wmf.11 - regression] "New filters for edit review" beta feature has no effect on Watchlist .Dec 7 2017, 1:38 PM
SBisson added a subscriber: Etonkovidova.
• Petar.petkovic removed projects: Patch-For-Review, Wikidata.Dec 7 2017, 1:41 PM
• Petar.petkovic updated the task description. (Show Details)
• Petar.petkovic added a project: Patch-For-Review.
Lydia_Pintscher subscribed.Dec 7 2017, 2:33 PM
• jmatazzoni subscribed.Dec 7 2017, 3:42 PM

Opting out of the beta works fine on en.wiki but not Wikidata. For me.

Trizek-WMF added a comment.Dec 7 2017, 4:21 PM

That's normal, @jmatazzoni. The deployment train is the following:

  • Tuesday 19:00-21:00 UTC: deployment on group0 (test wikis and mw.org)
  • Wednesday 19:00-21:00 UTC: group1 (non-Wikipedias, Catalan and Hebrew Wikipedias)
  • Thursday 19:00-21:00 UTC: group2 (other Wikipedias)
gerritbot added a comment.Dec 7 2017, 4:31 PM

Change 396003 merged by jenkins-bot:
[mediawiki/core@master] WLFilters: Correctly check if RCFilters should be enabled on WL

https://gerrit.wikimedia.org/r/396003

gerritbot added a comment.Dec 7 2017, 4:35 PM

Change 396054 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@wmf/1.31.0-wmf.11] WLFilters: Correctly check if RCFilters should be enabled on WL

https://gerrit.wikimedia.org/r/396054

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Dec 7 2017, 5:00 PM
gerritbot added a comment.Dec 7 2017, 7:16 PM

Change 396054 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.11] WLFilters: Correctly check if RCFilters should be enabled on WL

https://gerrit.wikimedia.org/r/396054

Stashbot subscribed.Dec 7 2017, 7:29 PM

Mentioned in SAL (#wikimedia-operations) [2017-12-07T19:29:43Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.11/includes/specialpage/ChangesListSpecialPage.php: SWAT: [[gerrit:396054|WLFilters: Correctly check if RCFilters should be enabled on WL]] T182318 (duration: 00m 48s)

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Dec 7 2017, 7:31 PM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)); removed MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Dec 7 2017, 8:00 PM
Etonkovidova added a comment.Dec 7 2017, 10:47 PM

Checked the fix in enwiki and hewiki (wmf.11).

Etonkovidova closed this task as Resolved.Dec 7 2017, 10:48 PM
Liuxinyu970226 unsubscribed.Dec 8 2017, 11:14 AM
• Petar.petkovic removed a project: Patch-For-Review.Mar 3 2018, 2:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL