Page MenuHomePhabricator

Filtering banners on campaign page resets "Limit traffic" checkbox and "Campaign type"
Open, Needs TriagePublic

Description

We're currently limiting our campaigns to 50% traffic, but had a couple of instances where they accidentally went back up to 100% when making other changes to the campaign. @TSkaff managed to figure out this is happening when using the "Filter banners" tool.

Steps to reproduce:

  1. Have a campaign with "Limit traffic" enabled and set to less than 100%
  2. Visit the admin page, enter something in the "Filter banners" input and click "Apply filter"
  3. When the page reloads the Limit traffic checkbox is no longer ticked, and saving the form would result in removing the traffic limit.

The "Campaign type" dropdown is similarly set to "No type (always shown)"

Event Timeline

This is still a problem, and has caught us out again this year. @AndyRussG any chance you could take a look?

Pcoombe renamed this task from Filtering banners on campaign page resets "Limit traffic" checkbox to Filtering banners on campaign page resets "Limit traffic" checkbox and "Campaign type".Oct 11 2021, 5:21 PM
Pcoombe updated the task description. (Show Details)

Noticed the "Campaign type" also gets reset when filtering banners