Page MenuHomePhabricator

FlaggedRevs / invalid file timestamps?
Closed, DuplicatePublicPRODUCTION ERROR

Description

Spotted in production, dewiki only: Wikimedia\Timestamp\ConvertibleTimestamp::setTimestamp: Invalid timestamp - 20081026161737.

Urls look like: /w/index.php?title=Datei:Example.jpg&filetimestamp=20081026161737

Stacktrace:

#0 /srv/mediawiki/php-1.31.0-wmf.10/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(68): Wikimedia\Timestamp\ConvertibleTimestamp->setTimestamp(string)
#1 /srv/mediawiki/php-1.31.0-wmf.10/includes/libs/rdbms/database/Database.php(3151): Wikimedia\Timestamp\ConvertibleTimestamp->__construct(string)
#2 /srv/mediawiki/php-1.31.0-wmf.10/includes/filerepo/file/OldLocalFile.php(238): Wikimedia\Rdbms\Database->timestamp(string)
#3 /srv/mediawiki/php-1.31.0-wmf.10/includes/filerepo/file/LocalFile.php(311): OldLocalFile->loadFromDB(integer)
#4 /srv/mediawiki/php-1.31.0-wmf.10/includes/filerepo/file/LocalFile.php(628): LocalFile->loadFromCache()
#5 /srv/mediawiki/php-1.31.0-wmf.10/includes/filerepo/FileRepo.php(443): LocalFile->load(integer)
#6 /srv/mediawiki/php-1.31.0-wmf.10/includes/filerepo/RepoGroup.php(154): FileRepo->findFile(Title, array)
#7 /srv/mediawiki/php-1.31.0-wmf.10/includes/GlobalFunctions.php(2922): RepoGroup->findFile(Title, array)
#8 /srv/mediawiki/php-1.31.0-wmf.10/extensions/FlaggedRevs/frontend/FlaggablePageView.php(925): wfFindFile(Title, array)
#9 /srv/mediawiki/php-1.31.0-wmf.10/extensions/FlaggedRevs/frontend/FlaggedRevsUI.hooks.php(162): FlaggablePageView->imagePageFindFile(boolean, boolean)
#10 /srv/mediawiki/php-1.31.0-wmf.10/includes/Hooks.php(177): FlaggedRevsUIHooks::onImagePageFindFile(ImagePage, boolean, boolean)
#11 /srv/mediawiki/php-1.31.0-wmf.10/includes/Hooks.php(205): Hooks::callHook(string, array, array, NULL)
#12 /srv/mediawiki/php-1.31.0-wmf.10/includes/page/ImagePage.php(75): Hooks::run(string, array)
#13 /srv/mediawiki/php-1.31.0-wmf.10/includes/page/ImagePage.php(114): ImagePage->loadFile()
#14 /srv/mediawiki/php-1.31.0-wmf.10/includes/actions/ViewAction.php(68): ImagePage->view()
#15 /srv/mediawiki/php-1.31.0-wmf.10/includes/MediaWiki.php(499): ViewAction->show()
#16 /srv/mediawiki/php-1.31.0-wmf.10/includes/MediaWiki.php(293): MediaWiki->performAction(ImagePage, Title)
#17 /srv/mediawiki/php-1.31.0-wmf.10/includes/MediaWiki.php(851): MediaWiki->performRequest()
#18 /srv/mediawiki/php-1.31.0-wmf.10/includes/MediaWiki.php(523): MediaWiki->main()
#19 /srv/mediawiki/php-1.31.0-wmf.10/index.php(43): MediaWiki->run()
#20 /srv/mediawiki/w/index.php(3): include(string)
#21 {main}

This could be bogus user input, but wanna make sure FlaggedRevs isn't generating these URLs.