Page MenuHomePhabricator
Create Task
Maniphest T182359

[wmf.11] "Uncaught TypeError: Cannot read property 'css' of undefined" when topics are sorted on SD boards
Closed, ResolvedPublic
Actions

Description

The issue is present in betalabs too.

On a SD board click to sort topics - the Console will display

Uncaught TypeError: Cannot read property 'css' of undefined
 at OoUiMenuSelectWidget.OO.ui.mixin.FloatableElement.computePosition
 at OoUiMenuSelectWidget.OO.ui.mixin.ClippableElement.getHorizontalAnchorEdge
 at OoUiMenuSelectWidget.OO.ui.mixin.ClippableElement.clip

Note: If Dev tools panel is opened at the bottom of the page and a SD board is clicked, then moving the dividing line will cause numerous errors such as above.

Details

ProjectBranchLines +/-Subject
oojs/uiv0.24.4+2 -2ClippableElement: Fix JS error when Floatable is mixed in but disabled
oojs/uimaster+2 -2ClippableElement: Fix JS error when Floatable is mixed in but disabled
mediawiki/corewmf/1.31.0-wmf.11+2 -2OOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988
mediawiki/corewmf/1.31.0-wmf.12+2 -2OOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988
mediawiki/coremaster+2 -2OOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Dec 7 2017, 9:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2017, 9:54 PM
Etonkovidova updated the task description. (Show Details)Dec 13 2017, 10:37 PM
Etonkovidova updated the task description. (Show Details)Dec 13 2017, 10:40 PM
Catrope added a subscriber: Catrope.Dec 14 2017, 2:14 AM

This is a regression from rGOJU42556397b792: ClippableElement: Allow clipping with top or left edge, breaking menus that have clipping enabled but positioning disabled (i.e. $floatableContainer is not set).

Catrope claimed this task.Dec 14 2017, 2:14 AM
Catrope edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Catrope moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a subscriber: gerritbot.Dec 14 2017, 2:18 AM

Change 398207 had a related patch set uploaded (by Catrope; owner: Catrope):
[oojs/ui@master] ClippableElement: Fix JS error when Floatable is mixed in but disabled

https://gerrit.wikimedia.org/r/398207

gerritbot added a project: Patch-For-Review.Dec 14 2017, 2:18 AM
Catrope moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Dec 14 2017, 2:19 AM
gerritbot added a comment.Dec 14 2017, 5:21 AM

Change 398207 merged by jenkins-bot:
[oojs/ui@master] ClippableElement: Fix JS error when Floatable is mixed in but disabled

https://gerrit.wikimedia.org/r/398207

matmarex mentioned this in T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working).Dec 14 2017, 10:51 PM
gerritbot added a comment.Dec 14 2017, 10:56 PM

Change 398384 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] OOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988

https://gerrit.wikimedia.org/r/398384

matmarex triaged this task as High priority.Dec 14 2017, 11:00 PM
matmarex edited projects, added OOUI; removed Patch-For-Review.
gerritbot added a comment.Dec 14 2017, 11:06 PM

Change 398384 merged by jenkins-bot:
[mediawiki/core@master] OOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988

https://gerrit.wikimedia.org/r/398384

gerritbot added a comment.Dec 14 2017, 11:28 PM

Change 398386 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@wmf/1.31.0-wmf.11] OOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988

https://gerrit.wikimedia.org/r/398386

gerritbot added a project: Patch-For-Review.Dec 14 2017, 11:28 PM

Change 398387 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@wmf/1.31.0-wmf.12] OOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988

https://gerrit.wikimedia.org/r/398387

gerritbot added a comment.Dec 15 2017, 12:21 AM

Change 398387 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.12] OOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988

https://gerrit.wikimedia.org/r/398387

gerritbot added a comment.Dec 15 2017, 12:22 AM

Change 398386 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.11] OOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988

https://gerrit.wikimedia.org/r/398386

Stashbot added a subscriber: Stashbot.Dec 15 2017, 12:25 AM

Mentioned in SAL (#wikimedia-operations) [2017-12-15T00:25:06Z] <catrope@tin> Synchronized php-1.31.0-wmf.12/resources/lib/oojs-ui/oojs-ui-core.js: Backport OOjs UI fix for T182359, T182395 (duration: 00m 57s)

matmarex closed this task as Resolved.Dec 15 2017, 12:31 AM
matmarex removed a project: Patch-For-Review.
matmarex added a subscriber: matmarex.

Fixed and deployed.

matmarex mentioned this in T183195: Release OOUI v0.24.4 with some backported patches.Dec 18 2017, 9:55 PM
gerritbot added a comment.Dec 19 2017, 8:07 PM

Change 399244 had a related patch set uploaded (by Bartosz Dziewoński; owner: Catrope):
[oojs/ui@v0.24.4] ClippableElement: Fix JS error when Floatable is mixed in but disabled

https://gerrit.wikimedia.org/r/399244

gerritbot added a project: Patch-For-Review.Dec 19 2017, 8:07 PM
gerritbot added a comment.Dec 19 2017, 8:18 PM

Change 399244 merged by jenkins-bot:
[oojs/ui@v0.24.4] ClippableElement: Fix JS error when Floatable is mixed in but disabled

https://gerrit.wikimedia.org/r/399244

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL