|mediawiki/core : wmf/1.31.0-wmf.11||Revert replacing textarea in Special:Undelete with OOUI|
|mediawiki/core : master||Revert replacing textarea in Special:Undelete with OOUI|
- Mentioned In
- T192335: Re-introduce MultilineTextInputWidget to Special:Undelete
T180207: Convert "Show diff" part of Special:Undelete to OOUI
T182426: OOUI MultilineTextInputWidget textboxes are grey in Monobook (Apex) but not in Vector (WikimediaUI theme)
- Mentioned Here
- rMWfa718359ec7c: Replace some Special:Undelete button with OOUI ones
Similar behaviour confirmed on my various mobile devices. Inspecting the source, the <div> tag ( of class "oo-ui-widget oo-ui-widget-enabled oo-ui-inputWidget oo-ui-textInputWidget oo-ui-textInputWidget-type-text oo-ui-textInputWidget-php") which immediately surrounds the <textarea> has CSS attributes "width: 100%; max-width: 50em;". Just getting rid of the max-width property in my browser console worked for me, so just remove that rule? Though why anyone put it there in the first place baffles me.
Did anyone bother to test this? This is borderline unusable. Screen size is 1920x1080.
For reference, I did test this and notice the narrow width (I even made a comment about it on irc), but assumed that it was intentional as part of ooui
I think for the time being we should revert the textarea aspect of the change but keep the button change.
Yes, I also want to emphasize that this is my fault for not catching it, and definitely not your fault. Its awesome if you want to fix it, but if you didn't want to, that would be ok to, and I would take care of it.
A quick analysis:
- This width is due to max-width: 50em in .oo-ui-textInputWidget class
- This class is added here: https://github.com/wikimedia/oojs-ui/blob/master/php/widgets/TextInputWidget.php#L88-L95
// Initialization $this ->addClasses( [ 'oo-ui-textInputWidget', 'oo-ui-textInputWidget-type-' . $this->type, 'oo-ui-textInputWidget-php', ] ) ->appendContent( $this->icon, $this->indicator );