| Lydia_Pintscher | |
| Dec 8 2017, 2:18 PM |
| F11693476: diffannotated.png | |
| Dec 8 2017, 2:26 PM |
As an editor patrolling recent changes I want to see meaningful diffs when someone changes a Form on a Lexeme so that I can easily check what is going on and decide if the change is beneficial or not.
Mock of how it should look with important part highlighted:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata | |||
| Resolved | Addshore | T168260 Deploy WikibaseLexeme extension on Wikimedia cluster | |||
| Resolved | Addshore | T191457 Deploy WikibaseLexeme on www.wikidata.org | |||
| Resolved | Addshore | T191458 Deploy WikibaseLexeme on test.wikidata.org | |||
| Resolved | Lydia_Pintscher | T168263 WikibaseLexeme functional baseline | |||
| Resolved | Lydia_Pintscher | T159703 [Tracking] Support for Forms and Senses | |||
| Resolved | Lydia_Pintscher | T150178 Wikidata 2017 Q2 goals | |||
| Resolved | Lydia_Pintscher | T169708 Wikidata 2017 Q3 goals | |||
| Resolved | Lydia_Pintscher | T160052 [Epic] Support for Forms | |||
| Resolved | Tarrow | T185481 [Bug] Unexpected order of Lexeme DataModel elements in complex diffs | |||
| Resolved | Ladsgroup | T182424 Diffs for statements, grammatical features and representations of a form (M) (days: 9) |
Open questions still:
Change 401934 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Accept path array to prepend to statement diff
Change 401959 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Start supporting diffs for forms
Both patches are now ready for review, it supports all types of changes in forms (grammatical features, statements, representations)
Change 403963 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Move path array prepending logic to ClaimDifferenceVisualizer
Change 403969 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fix mistakes and refactor FormDiffView and related
Question to @Lydia_Pintscher: We did not specified in which order changes should show up in diffs. For Items and Properties the order is identical to the order in which the elements appear in all data model specifications. For Forms this is currently not the case. for example, grammatical features are shown after the Forms statements. And statements that belong directly to the Lexeme are shown after Forms and Senses.
This is only relevant when an edit touches multiple sections. The best way to reproduce this issue is two compare two entirely different Lexemes via Special:Diff/…/….
My question is if we should make an expected order part of the acceptance criteria for this ticket, or create a separate ticket for this detail?
Let's put it in a separate ticket. Can you show me in-person so I get the details? Then I can create it. Or you can create it.
Change 401934 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Accept path array to prepend to statement diff
Change 401959 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Diff support for forms
https://gerrit.wikimedia.org/r/403969 was meant to be part of this, and merged to call this "done". Otherwise I would not have merged https://gerrit.wikimedia.org/r/401959. I even wrote this in a comment when I added my +2 to https://gerrit.wikimedia.org/r/401959.
Change 403969 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix mistakes and refactor FormDiffView and related
Change 403963 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move path array prepending logic to ClaimDifferenceVisualizer