json to entry conversion should report errors if they don't match
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	HannaLindgren
	Dec 11 2017, 3:41 PM

Description

Example (line 356 in lexserver/lexicon.go)
err = json.Unmarshal([]byte(entryJSON), &e)

Currently, an input json entry with a transcription attribute (instead of a transcriptions list) will not generate an error when converted from json to lex.Entry.
We should fix this.

Related issues: T144792, T181624

Related Objects

Mentioned In: T144792: Decide how dbapi.UpdateEntry (and corresponding http server call) should deal with incomplete or inconsistent entries
Mentioned Here: T144792: Decide how dbapi.UpdateEntry (and corresponding http server call) should deal with incomplete or inconsistent entries
T181624: Entry added even if entry string is invalid

Event Timeline

HannaLindgren created this task.Dec 11 2017, 3:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2017, 3:41 PM

HannaLindgren added projects: Wikispeech-STTS, Wikispeech-Lexicon, Wikispeech.Dec 11 2017, 3:42 PM

HannaLindgren removed subscribers: Wikispeech, Wikispeech-Lexicon, Wikispeech-STTS.

HannaLindgren triaged this task as Low priority.Dec 11 2017, 3:44 PM

HannaLindgren updated the task description. (Show Details)Dec 11 2017, 4:08 PM

HannaLindgren mentioned this in T144792: Decide how dbapi.UpdateEntry (and corresponding http server call) should deal with incomplete or inconsistent entries.

@HannaLindgren Thanks for raising this issue. I will like to work on it. :)

HannaLindgren closed this task as Declined.Oct 23 2019, 9:37 AM

json to entry conversion should report errors if they don't matchClosed, DeclinedPublicActions

Description

Related Objects

Event Timeline

json to entry conversion should report errors if they don't match
Closed, DeclinedPublic
Actions