[BUG] Article "Find in Page" not working for search terms containing apostrophe
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Dec 11 2017, 10:49 PM

Description

How many times were you able to reproduce it?

All

Steps to reproduce

Load enwiki > Nigel (bishop of Ely)
Tap Find in Page icon and search for Stephen's

Expected results

Should find some matches

Actual results

No matches

Environments observed

App version:
5.7.3

OS versions:
iOS 11

Device model:
All

Device language:
All

Event Timeline

Mhurd created this task.Dec 11 2017, 10:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2017, 10:49 PM

Mhurd moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 11 2017, 10:52 PM

I pinged @JMinor before fixing (was quick fix).
https://github.com/wikimedia/wikipedia-ios/pull/1978

Mhurd moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 12 2017, 7:08 PM

JoeWalsh moved this task from Waiting for Build to Needs QA on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 15 2017, 12:11 PM

Working now on 5.7.3 (1281)

Change 400192 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Newsletter@master] Add a unit test to check that the main page must be unique per newsletter

https://gerrit.wikimedia.org/r/400192

gerritbot added a project: Patch-For-Review.Dec 25 2017, 8:32 PM

Oops, ignore that, made a typo in my bug id

Pppery removed subscribers: Pppery, gerritbot.Dec 25 2017, 8:34 PM

• JMinor triaged this task as Low priority.Jan 8 2018, 7:10 PM

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Jan 8 2018, 7:14 PM

• JMinor closed this task as Resolved.Jan 8 2018, 10:36 PM

[BUG] Article "Find in Page" not working for search terms containing apostropheClosed, ResolvedPublicActions