Handle interwiki links in media `link=` params
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Arlolra
	Dec 12 2017, 2:32 AM

Description

In https://gerrit.wikimedia.org/r/#/c/396067/ @cscott exposed this,

$ echo "[[File:Foobar.jpg|alt=galleryalt|link=meatball:Link]]" | node bin/parse --normalize
<p><figure-inline><a href="Meatball:Link"><img alt="galleryalt" src="//upload.wikimedia.org/wikipedia/commons/3/3a/Foobar.jpg" data-file-width="240" data-file-height="28" data-file-type="bitmap"  height="28" width="240"/></a></figure-inline></p>

In handleInfo, the o.hasLink case (https://github.com/wikimedia/parsoid/blob/master/lib/wt2html/tt/LinkHandler.js#L1432-L1459) probably needs a call to getWikiLinkTargetInfo instead of just the makeTitleFromText

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	WIP: Fix media with `link=` pointing to an interwiki link	mediawiki/services/parsoid	master	+71 -15

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	BUG REPORT	None	T337143 Interwiki links from images don't open in the android app
		Open		None	T182649 Handle interwiki links in media `link=` params

Event Timeline

Arlolra created this task.Dec 12 2017, 2:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2017, 2:32 AM

Arlolra triaged this task as Medium priority.Dec 12 2017, 2:32 AM

Let's add a test case for T95473: Interwiki links whose titles contain question marks are not properly escaped in HTML output. whenever we get around to making interwiki links work properly in galleries.

ssastry moved this task from Needs Triage to Link syntax (links & media) on the Parsoid board.Jun 10 2019, 8:07 PM

ssastry lowered the priority of this task from Medium to Low.Feb 28 2020, 5:14 PM

ssastry moved this task from Link syntax (links & media) to Bugs & Crashers on the Parsoid board.

Arlolra raised the priority of this task from Low to Medium.Aug 19 2021, 3:58 PM

Arlolra merged a task: T289205: Parsoid generates incorrect links for wikidata interwiki links used in images .

Arlolra added a subscriber: ssastry.

T18409 is another case that would benefit from a call to getWikiLinkTargetInfo

Arlolra added a parent task: T337143: Interwiki links from images don't open in the android app.May 22 2023, 4:39 PM

cscott mentioned this in T337143: Interwiki links from images don't open in the android app.May 25 2023, 2:13 PM

Nickolas subscribed.Oct 4 2023, 9:34 PM

Change #1095481 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] WIP: Fix media with `link=` pointing to an interwiki link

https://gerrit.wikimedia.org/r/1095481

gerritbot added a project: Patch-For-Review.Dec 4 2024, 12:05 AM

Handle interwiki links in media `link=` paramsOpen, MediumPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Handle interwiki links in media `link=` params
Open, MediumPublic
Actions

Related Objects
Search...