Page MenuHomePhabricator
Create Task
Maniphest T182670

When switching groups of filters, search criteria sticks, but not applied
Closed, ResolvedPublic
Actions

Assigned To
None
Authored By
• Petar.petkovic
Dec 12 2017, 12:21 PM
Tags
Referenced Files
F12229125: Screen Shot 2018-01-03 at 10.52.03 AM.png
Jan 3 2018, 6:57 PM
F12229132: Screen Shot 2018-01-03 at 10.55.37 AM.png
Jan 3 2018, 6:57 PM
F12229130: Screen Shot 2018-01-03 at 10.55.14 AM.png
Jan 3 2018, 6:57 PM
F12229122: Screen Shot 2018-01-03 at 10.51.54 AM.png
Jan 3 2018, 6:57 PM
F11786501: searching-filters.gif
Dec 12 2017, 12:21 PM
Subscribers
Aklapper
Etonkovidova
• jmatazzoni
Mooeypoo
• Petar.petkovic
SBisson
Trizek-WMF

Description

  1. Open filters menu and type some search criteria
    • Main filter group is filtered using search criteria
  2. Change filter group to Namespaces or Tags
  3. Search criteria stays the same, but all filters are displayed
    • Expected behavior would be that search criteria and search results are in sync:
      • If we keep search criteria, we would need to re-apply it on different filters group
      • If we want fresh state, we need to reset search criteria when changing filter groups

searching-filters.gif (940×778 px, 989 KB)

Other bugs/inconsistencies visible on gif above:

  • "No filters found" is looking differently on main filter group vs namespace group. Message on namespace group has more space at the bottom.
  • In some scenarios, "No filters found" is not displayed on namespace group

Related Objects
Search...

Event Timeline

• Petar.petkovic created this task.Dec 12 2017, 12:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2017, 12:21 PM
Trizek-WMF added a project: Edit-Review-Improvements-Integrated-Filters.Dec 12 2017, 6:15 PM
Trizek-WMF subscribed.
• Petar.petkovic added a subtask: T182720: Clean up the synchronization and updating of menu items with the search input.Dec 12 2017, 10:24 PM
Etonkovidova added a comment.Jan 3 2018, 6:57 PM

@Petar.petkovic comment:

"No filters found" is looking differently on main filter group vs namespace group. Message on namespace group has more space at the bottom.

The reason of not having the consistent look might be due to the back arrow icon to navigate from Namespaces/Tags back to Filters. It's not so noticeable when search criteria return results for Filters and Tags.

No results:

Screen Shot 2018-01-03 at 10.51.54 AM.png (262×696 px, 42 KB)
Screen Shot 2018-01-03 at 10.52.03 AM.png (204×720 px, 28 KB)

When some results are returned:

Screen Shot 2018-01-03 at 10.55.14 AM.png (400×660 px, 64 KB)
Screen Shot 2018-01-03 at 10.55.37 AM.png (229×670 px, 40 KB)

I re-checked the issue - it seems to be working quite logical now (it's fixed in wmf.15 - testwiki and mediawiki).

  • In the filter search area enter e.g. "edit" - the Filters names/description containing "edit" will be displayed.
  • Switch to Namespaces filters - "edit" will become ":edit" and "No filters found" will be displayed
  • switch to Tags filters -":edit" will become "#edit" and some Tags will be displayed.

So, the filters from different groups (Namespace, Tags) will be displayed according to entered search criteria. I am closing the ticket as resolved.

Etonkovidova closed this task as Resolved.Jan 3 2018, 6:57 PM
• Petar.petkovic added a comment.Jan 3 2018, 7:18 PM
In T182670#3872443, @Etonkovidova wrote:

"No filters found" is looking differently on main filter group vs namespace group. Message on namespace group has more space at the bottom.

The reason of not having the consistent look might be due to the back arrow icon to navigate from Namespaces/Tags back to Filters. It's not so noticeable when search criteria return results for Filters and Tags.

No results:

Screen Shot 2018-01-03 at 10.51.54 AM.png (262×696 px, 42 KB)
Screen Shot 2018-01-03 at 10.52.03 AM.png (204×720 px, 28 KB)

Actually, black arrow is not the reason why I said "No filters found" looks different. There is more white space on the bottom for Tags/Namespaces compared to regular filter view. You can see that clearly on two images you posted under "No results". The reason is that one parent elements has min-height, but that white space is not causing any problems, so probably not worth solving.

The other issue was that, after some weird sequence of actions, you get no filters as search results, but message "No filters found" isn't showing. You can see that on the end of gif from description.

I have checked reported issues on Mediawiki and everything works smoothly now. Thank you @Mooeypoo for dealing with this!

Etonkovidova closed subtask T182720: Clean up the synchronization and updating of menu items with the search input as Resolved.Jan 3 2018, 11:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits