Page MenuHomePhabricator

[BUG] Regression - User is shown an app selection bottom sheet every single time certain external links are tapped
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce
  1. Open the app and navigate to Settings > About the Wikipedia app page
  2. Tap on any link within that page
  3. Return to the Explore feed and now tap on the "Support Wikipedia" menu option in the overflow
  4. Navigate to the Login screen and tap on the "Forgot your password" or "Password "Policy" links
Expected

When tapping on the links in steps 2, 3, and 4, the user should be taken directly to the default web browser for their device.

Actual

A bottom sheet appears asking to select the web browser app *every* time the user taps to open links in steps 3 and 4.

Occurring on

Initially detected in T181149#3808708 on Nexus 5(6.0.1), Wikipedia v2.6.206-alpha-2017-12-04:

app-ChooserActivity-12042017135031.png (1×1 px, 390 KB)

  • Now also occurring on Pixel (8.0.0), Wikipedia v2.7.221-alpha-2017-12-12.**

Event Timeline

@RHo

I did couple tests and still not able to reproduce it.

Could you help me to check the following setting?

Settings -> Apps -> Wikipedia -> Open by default

Fullscreen_12_12_17__4_53_PM.png (549×336 px, 34 KB)

Also, have you ever clicked on any deep links (*.wikipedia.org) on any web browsers and choose always open by other apps?

If it is possible, please help me to clear the settings in Open by default and try to reproduce it again, thank you!

Fullscreen_12_12_17__4_59_PM.png (585×330 px, 27 KB)

hey @cooltey - I cleared the settings in Open by default in Wikipedia, and am able to reproduce the issue:
https://youtu.be/6mPOvtkUFMI

Note that my Chrome app also has no defaults set under 'open by default' either.

@RHo
Thanks for providing the demo video, it helps a lot!

Note for myself:

While investigating this issue, I have created a custom dialog to allow users to choose a browser to open the link, but it might cost extra storage to store the actions (just once or always) just like the general one.

Now we've handled the *.wikipedia.org links to open our app when clicking it from browser, and it also happens when clicking it on our app so that it would cause an infinite loop.

The best way to handle this could be add an excepted logic to redirect it. (But not sure if it is worthy...)

cooltey subscribed.
Restricted Application changed the subtype of this task from "Task" to "Bug Report". · View Herald TranscriptApr 13 2020, 4:55 PM

Let's see if this still happens now we have changed the logic for this.

Can't reproduce on my devices; passing to QA.

Dbrant claimed this task.