Page MenuHomePhabricator

Make supporter list work on mobile
Closed, ResolvedPublic5 Estimated Story Points

Description

T179938 provided a basic integration of the existing Unterstützerliste mark-up (from content repo) with the cat17 skin layout.

In contrast to the design delivered it...

  • does NOT work on small screens yet
  • does NOT show comment icon (in particular not only when a comment is available)
  • is NOT click-based but only reacts to hover

AC:

  • If an entry contains a comment, an icon is displayed (see delivered design)
  • Hovering over items displays the comment
  • Clicking on items displays its comment
  • Only one comment is shown at a time
  • In narrow/mobile views, the comment is displayed below the respective entry
  • In wide/desktop views, the comment is displayed right of the respective entry
  • The display in the 10h16 skin is not being affected

Info

Related Objects

Event Timeline

kai.nissen set the point value for this task to 5.
kai.nissen moved this task from Backlog to Sprint ready on the WMDE-Fundraising-Tech board.
kai.nissen renamed this task from Make Unterstützerliste work on mobile to Make supporter list work on mobile.May 2 2018, 1:26 PM
kai.nissen raised the priority of this task from Low to Medium.

As discussed: Removed the hover functionality and now relying on clicks only.

Removed support for hover event to decrease implementation effort. This page was visited ~2000 times during last year's campaign btw.

Relevant pull requests:
https://github.com/wmde/FundraisingFrontend/pull/1228 - More general preparation to allow for custom templates on custom pages
https://github.com/wmde/FundraisingFrontend/pull/1229 - Actual CSS / JS changes

Tim_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2018-05-02 board.