Page MenuHomePhabricator

Clean up the synchronization and updating of menu items with the search input
Closed, ResolvedPublic

Description

Due to the way we select, highlight and scroll-to items in the filter menu, there's been a mismatch and a break of synchronization between the search entry in the actual input and the filters shown.

We have to wait until the display is ready in order to scroll down to the actual item in the DOM, so the "hacks" of waiting created a mismatch in certain cases (like when selecting a tag item "bubble" from the active filters area) with the input text/filtering. This should be fixed and standardized properly.

This probably causes at least some of the bugs in both T178540: RC page - the page jumps when filter capsules are clicked while searching and T182676: A change on the targeted category or portal on RecentChangesLinked doesn't loads new results

Event Timeline

Change 397996 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] [wip] RCFilters: Synchronize input with menu filters

https://gerrit.wikimedia.org/r/397996

Change 397996 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Create one single source of truth for item display

https://gerrit.wikimedia.org/r/397996

Closing as Resolved - all related tasks have been verified and resolved.