Page MenuHomePhabricator

Black mode article view
Closed, ResolvedPublic

Description

Currently there are a few colors ares in Black mode Article view that need to be updated in order to help with reading ease and to reflect the styles defined in T181847


Article body

Zeplin: https://zpl.io/bAOLWvq

Current stateDesigned state
IMG_CAE101AB02E7-1.jpeg (1×750 px, 435 KB)
Screen Shot 2017-12-12 at 3.23.49 PM.png (579×382 px, 153 KB)

Updates needed

  • Tables should utilize the Mid-background color as defined in the Black mode theme (#222)

Article footer

Zeplin: https://zpl.io/bAOLWvq

Current stateDesigned state
IMG_4757.PNG (1×750 px, 405 KB)
Screen Shot 2017-12-12 at 3.07.54 PM.png (649×384 px, 75 KB)

Updates needed

  • About this article table and Read more cards should use the Mid-background color as defined in the Black mode theme (#222)
  • Footer background color should use the Base color as defined in the Black mode theme (#101418)

Event Timeline

cmadeo triaged this task as Medium priority.Dec 12 2017, 11:25 PM
cmadeo created this task.

@cmadeo ^ see the PR above for before/after screenshots.

Testing criteria

  • load any article
  • tap the article theme tT icon (second from bottom right)
  • select the third circular color button - the dark mode button
  • note the article background color
  • select the fourth circular color button - the black mode button
  • ensure the article background became darker when you selected the black button