Change 398267 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] Randomizer offline behavior - Remove perpetual spinner

https://gerrit.wikimedia.org/r/398267

@RHo the errorView looks like this : https://youtu.be/0qrnCVT1OxQ . fyi..When the device comes back online, we are still able to see the error view for a couple times on back swipe/click.

I kind of think it would be better if the spinner and the ErrorView are inside the card, instead of floating disembodied on the blue surface.

hi @Sharvaniharan - agree with @Dbrant that the spinner and error message should be inside the card.
I.e. Expected error state in Light & Dark modes:

Also noticed that even initially entering the Randomizer view (with connectivity) in your demo, the spinner is showing up outside of the card and appears to be an animated gif on white background, instead of the expected loader:

Expected on load spinner in Light mode:	Expected in dark mode:	Actual (from video)

Change 398267 merged by jenkins-bot:
[apps/android/wikipedia@master] Randomizer offline behavior - Remove perpetual spinner

https://gerrit.wikimedia.org/r/398267

hi @Sharvaniharan - please just center the message in the card and then it will be OK for QA.
Expected:

Actual:

@RHo The Error view is an independent view that is getting used through out the app, and the misalignment is in that view and not on the randomizer view. We must nevertheless fix it, I have opened this and kept it in ready-for-dev on g board for now. I will try to fix it by end of day today, if possible, after my other planned tasks are over. If it gets fixed then i will unblock this ticket and move it to QA. Unless you feel we can move this to QA for now, and once the error view is fixed, the expectation is that this and all other places where it is displayed will be fixed. Let me know how to move on this.

hi @Sharvaniharan - i just took a look at the ticket T183555 filed to fix the error view. Can you clarify which screens it is misaligned? As far as I can see, the error view is aligned correctly in the other places where it is shown (eg 'Other languages', Search) and it is only in this Randomizer offline card that I have seen it be misaligned...

Eg. Appearing as expected in Other Languages:	In Search

Please fix the alignment on this ticket (error message alignment in Randomizer) before moving this ticket on.

@RHo we can take the same image that you have posted as an example... it actually is not vertically centered, it is off by around 32+ pixels.. however, the background being the same as the parent, makes it feel centered. Here is a colored errorview screenshot, you can see that the errorview is actually centered in the screen, but the views inside are off.

Ah fair enough @Sharvaniharan - in that case can this be placed in waiting until the other ticket is resolved?

Yes... i feel so too...

Looks fixed on 2.7.224-alpha-2018-01-10. Tested on a Pixel.