Page MenuHomePhabricator

Move non executable php code out of maintenance folder
Open, Needs TriagePublic

Description

Following up T177239

There's various .inc files that shouldn't be in maintenance... For example, someone unfamiliar with mediawiki might try and run backup.inc and wonder why it's not creating a backup.

Flow, for example, subclasses BackupDumper to make FlowDumpBackup, but also has a superfluous line of require_once $maintPath . '/backup.inc'; which isn't needed because the base class is in the MW autoloader

Targets for moving include.... 7zip.inc, backup.inc, backupPrefetch.inc

Event Timeline

Where are these going to be moved?

Change 455584 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn):
[mediawiki/core@master] move 7zip.inc to a regular php file

https://gerrit.wikimedia.org/r/455584

Change 455584 had a related patch set uploaded (by Jforrester; owner: ArielGlenn):
[mediawiki/core@master] move 7zip.inc to a regular php file

https://gerrit.wikimedia.org/r/455584

Change 455584 merged by jenkins-bot:
[mediawiki/core@master] move 7zip.inc to a regular php file

https://gerrit.wikimedia.org/r/455584

Now that the files named in the task description have all been moved, how about the rest of the *inc files in maintenance? We have:

cleanupTable.inc CodeCleanerGlobalsPass.inc commandLine.inc sqlite.inc userDupes.inc

Do we care about any of those? (Note, my involvement is likely done as none of those are dumps-related.)