Page MenuHomePhabricator
Create Task
Maniphest T182843

Black mode reference highlight color doesn't stand out from overlay color
Closed, ResolvedPublic
Actions

Description

The color in WMFReferencePageBackgroundView used to create the little highlight around reference(s) doesn't have contrast with the rest of the overlay background:

33967393-2fe102a6-e018-11e7-8f60-c2e3c4eb952c.png (1×862 px, 191 KB)

Switch to other themes to see highlighting around the currently selected reference [1] link(s) which is missing.

Event Timeline

Mhurd created this task.Dec 14 2017, 2:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2017, 2:28 AM
Mhurd updated the task description. (Show Details)Dec 14 2017, 2:34 AM
Mhurd claimed this task.Dec 14 2017, 9:07 PM
Mhurd moved this task from Tasks from Product Backlog to Doing on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.
Mhurd added a comment.Dec 14 2017, 10:46 PM

https://github.com/wikimedia/wikipedia-ios/pull/1987/commits/1bcbbe14da3a4f8a04e7172928206877e106c21b

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 14 2017, 10:46 PM
Mhurd moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 14 2017, 11:25 PM
Mhurd added a comment.Dec 14 2017, 11:38 PM

Testing criteria

  • enable Black theme
  • load an article like enwiki > Fire
  • tap a reference link such as [1]
  • ensure that the reference link has a little highlight box around it (the area around [1] should be slightly brighter than the background around it)

Here's how it should look:

Screen Shot 2017-12-14 at 3.33.12 PM.png (1×862 px, 239 KB)

Mhurd moved this task from Needs Testing Criteria to Waiting for Build on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 14 2017, 11:38 PM
JoeWalsh moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 15 2017, 12:10 PM
cmadeo moved this task from Needs Design Review to Needs QA on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 15 2017, 7:28 PM
cmadeo subscribed.

Thanks for catching this and fixing it, @Mhurd!

ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.EditedDec 15 2017, 10:11 PM
ABorbaWMF subscribed.

Looking good to me as well on 5.7.3 (1287)

• JMinor triaged this task as Low priority.Jan 8 2018, 7:12 PM
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
• JMinor closed this task as Resolved.Jan 8 2018, 10:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL