Page MenuHomePhabricator

[Bug] Help/question mark icons in "add new form/sense" toolbars are dysfunctional
Closed, ResolvedPublic

Description

When adding a new form or sense and hovering the question mark icon next to "save | cancel", no help tooltip appears, but an exception in the JavaScript console. The reason is that the two jquery.wikibase.lexemeformview.js and jquery.wikibase.senseview.js do not specify a default helpMessage in their default options.

This can be fixed either way:

  • Add helpMessage options to the two views. This implies actually specifying what these messages should say.
  • Make these messages optional.

I suggest the later. Patch-For-Review:

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptDec 14 2017, 3:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 398274 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Make (get)HelpMessage optional in $.wikibase.edittoolbar.js

https://gerrit.wikimedia.org/r/398274

Change 398275 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Remove unused helpMessage code from senseview

https://gerrit.wikimedia.org/r/398275

thiemowmde triaged this task as Low priority.Dec 14 2017, 3:39 PM
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from incoming to ready to go on the Wikidata board.

Change 398274 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make (get)HelpMessage optional in $.wikibase.edittoolbar.js

https://gerrit.wikimedia.org/r/398274

Change 398275 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove unused helpMessage code from senseview

https://gerrit.wikimedia.org/r/398275

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 22 2017, 3:14 PM

Seems to be fixed, tested on wikidata-lexeme.