Page MenuHomePhabricator

Show an informative preview when the backend service responds with an error
Closed, DeclinedPublic

Description

Background

Context: T182639#3832496 onwards.

In T182639: Page previews cannot handle empty responses gracefully - throws error in beta cluster and doesn't display preview (browser tests were failing), we discovered that Page Previews doesn't handle "successful" responses with invalid shapes or responses that indicate that there's been an error in the backend service (AKA "5xx code").

Design

Zeplin:
Mock:

AC

  • If the backend service responds with a 5xx code, then an "error preview" (see mock above) is shown

Event Timeline

phuedx created this task.Dec 14 2017, 6:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2017, 6:37 PM

@Nirzar - would it be okay/easier just to use the old one?

@ovasileva: It would be easier. However, there is a clear difference between the server responding with an error and there being no summary available (and it isn't semantic IMO).

phuedx added a comment.EditedDec 15 2017, 10:41 AM

@ovasileva: Is this a blocker for the deploy in Q3?

@ovasileva: Is this a blocker for the deploy in Q3?

I wouldn't consider it a blocker

can we use the same one with a different text?

I would prefer looking at frequency of 500s before making this a non-blocker, but again I defer to @ovasileva

ovasileva triaged this task as Normal priority.Dec 15 2017, 2:57 PM
ovasileva moved this task from Backlog to Needs Analysis on the Page-Previews board.

Perhaps we can just change the copy, I don't think we need multiple "empty" previews. Maybe something like: “There was an issue displaying this preview”

I'll make a task for the new copy. Note: change "read" to "go to this page"