Page MenuHomePhabricator
Create Task
Maniphest T182907

Link inspector overlapped by toolbar and extends past the screen when it opens upwards (only when editing links in tables and references)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Reported on mw. org.
The list of links can appear above the link itself, it can appear far from the point where it's expected to be, or the toolbar can get displayed on the top of the results.
I promise the images explain it better:
https://commons.wikimedia.org/wiki/File:TableError1.png; https://commons.wikimedia.org/wiki/File:TableError2.png (these are with Google Chrome, operating system Windows 10 and Vector skin).

image.png (790×1 px, 211 KB)

image.png (787×1 px, 259 KB)

Schermata 2017-12-14 alle 19.38.04.png (522×536 px, 77 KB)
(mine is on Safari, Sierra 10.12.6.)
(Assuming OOjs UI may be related.)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (8c5e78c7f)mediawiki/extensions/VisualEditorwmf/1.31.0-wmf.15+1 -1
Update VE core submodule to master (8c5e78c7f)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui.DesktopContext: Do not flip the popupVisualEditor/VisualEditormaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Elitre created this task.Dec 14 2017, 7:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2017, 7:18 PM
• Elitre mentioned this in T182999: Namespace selection dropdown opens in the wrong direction, Special page tab overlaps.Dec 15 2017, 4:42 PM
• Elitre mentioned this in T182711: Recent changes: Filter menu opens upwards.Dec 15 2017, 5:25 PM
matmarex added a subtask: T183069: Issues with OOUI menus/popups that open upwards being overlapped by things.Dec 16 2017, 9:35 PM
matmarex renamed this task from The link inspector can behave weirdly when editing links in tables and references to Link inspector overlapped by toolbar and extends past the screen when it opens upwards (only when editing links in tables and references).Dec 16 2017, 10:03 PM
matmarex claimed this task.
matmarex removed a project: OOUI.
matmarex updated the task description. (Show Details)
He7d3r mentioned this in T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards.Dec 28 2017, 12:31 PM
He7d3r subscribed.
gerritbot subscribed.Dec 30 2017, 3:23 AM

Change 400954 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.DesktopContext: Do not flip the popup

https://gerrit.wikimedia.org/r/400954

gerritbot added a project: Patch-For-Review.Dec 30 2017, 3:23 AM
• Deskana triaged this task as High priority.Jan 2 2018, 12:45 PM
• Deskana set the point value for this task to 1.
• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot added a comment.Jan 2 2018, 8:04 PM

Change 400954 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.DesktopContext: Do not flip the popup

https://gerrit.wikimedia.org/r/400954

gerritbot added a comment.Jan 2 2018, 8:10 PM

Change 401599 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (90a2a3834)

https://gerrit.wikimedia.org/r/401599

matmarex mentioned this in T183069: Issues with OOUI menus/popups that open upwards being overlapped by things.Jan 3 2018, 3:34 PM
gerritbot added a comment.Jan 3 2018, 6:46 PM

Change 401599 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8c5e78c7f)

https://gerrit.wikimedia.org/r/401599

matmarex mentioned this in T183590: Multi-part templates are rendered backwards and have a slug inside them.Jan 3 2018, 6:49 PM
gerritbot added a comment.Jan 3 2018, 6:50 PM

Change 401771 had a related patch set uploaded (by Bartosz Dziewoński; owner: Jforrester):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.15] Update VE core submodule to master (8c5e78c7f)

https://gerrit.wikimedia.org/r/401771

gerritbot added a comment.Jan 3 2018, 8:02 PM

Change 401771 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.15] Update VE core submodule to master (8c5e78c7f)

https://gerrit.wikimedia.org/r/401771

Stashbot subscribed.Jan 3 2018, 8:16 PM

Mentioned in SAL (#wikimedia-operations) [2018-01-03T20:16:06Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.15/extensions/VisualEditor/lib/ve: SWAT: [[gerrit:401771|Update VE core submodule to master]] T182907 T183590 (duration: 01m 06s)

matmarex closed this task as Resolved.Jan 3 2018, 8:35 PM
matmarex edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)); removed Patch-For-Review.

Fixed and deployed to wmf.15 (will go out this week).

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 3 2018, 8:35 PM
matmarex closed subtask T183069: Issues with OOUI menus/popups that open upwards being overlapped by things as Resolved.Jan 3 2018, 8:46 PM
Ryasmeen added projects: Verified, Verified-in-Phase0, Verified-in-Phase2.Jan 4 2018, 11:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits