Maniphest T183012

Clean up _pages.scss
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

None

Authored By

	gabriel-wmde
	Dec 15 2017, 5:33 PM

Tags

Referenced Files

None

Subscribers

• Tonina_Zhelyazkova_WMDE

Description

As a developer,
I want to be sure that the provided CSS is meaningful, applicable, and well-structured,
so that I can provide the least amount of styles to the user (for performance), can debug visual inconsistencies quickly and know where to find which styles

Acceptance Criteria:

All styles still in skins/cat17/src/sass/layout/_pages.scss are moved either to standalone subpages in skins/cat17/src/sass/layout/pages/ and included in _pages.scss or deleted.
Site looks like before (or "better").

Hints:

Compare with the HTMl from the 3rd party to see where the classes are/were used
You might need to add a page- prefix before some classes because we introduced the Twig page_identifier that automatically gets the prefix.
You might revert https://github.com/wmde/FundraisingFrontend/pull/1124 to see pages where the page_identifier is missing.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T188400 Follow up on skin integration
		Resolved		None	T183012 Clean up _pages.scss

Event Timeline

gabriel-wmde created this task.Dec 15 2017, 5:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2017, 5:33 PM

gabriel-wmde updated the task description. (Show Details)Dec 15 2017, 5:35 PM

kai.nissen added a parent task: T188400: Follow up on skin integration.Feb 27 2018, 4:42 PM

kai.nissen set the point value for this task to 3.Apr 10 2018, 1:51 PM

kai.nissen moved this task from Backlog to Sprint ready on the WMDE-Fundraising-Tech board.Apr 10 2018, 4:07 PM

• Tonina_Zhelyazkova_WMDE claimed this task.Aug 14 2018, 2:17 PM

• Tonina_Zhelyazkova_WMDE added a project: WMDE-FUN-Sprint-2018-08-06.

• Tonina_Zhelyazkova_WMDE moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.

• Tonina_Zhelyazkova_WMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2018-08-06 board.

Seems like this was done. The file looks as described in the AC.

• Tonina_Zhelyazkova_WMDE closed this task as Resolved.Aug 14 2018, 2:58 PM

• Tonina_Zhelyazkova_WMDE removed • Tonina_Zhelyazkova_WMDE as the assignee of this task.

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Done on the WMDE-FUN-Sprint-2018-08-06 board.

• Tonina_Zhelyazkova_WMDE subscribed.