tl;dr: scap 3.7.4-2 was released without quilt patches applied.
Scap 3.7.4-1 was deployed on 2017-12-11
on 2017-12-14 @demon noticed that scap was building a git directory in /srv/mediawiki/. That functionality is behind a feature flag on the release branch of scap https://github.com/wikimedia/scap/blob/release/scap/main.py#L334 we figured out that v.3.7.4-1 was cut from the master branch and not the release branch. I reopend T182347 and that was resolved this morning 2017-12-14 with the deploy of 3.7.4-2.
at 14:37UTC @Legoktm discovered that targets were looking at /srv/deployment/scap/scap/bin/scap as the path to scap. This is a configuration value that is overridden via quilt (https://github.com/wikimedia/scap/blob/release/debian/patches/change-bin-dir.patch) that did not get applied in 3.7.4-2 evidently.
[14:37:11] <legoktm> 22:36:59 ['/srv/deployment/scap/scap/bin/scap', 'pull', '--no-update-l10n', '--include', 'php-1.31.0-wmf.12', '--include', 'php-1.31.0-wmf.12/extensions', '--include', 'php-1.31.0-wmf.12/extensions/LoginNotify', '--include', 'php-1.31.0-wmf.12/extensions/LoginNotify/includes', '--include', 'php-1.31.0-wmf.12/extensions/LoginNotify/includes/LoginNotify.php', 'tin.eqiad.wmnet', 'naos.codfw.wmnet', 'tin.eqiad.wmnet'] on mw1264.eqiad.wmnet returned : bash: /srv/deployment/scap/scap/bin/scap: No such file or directory [14:37:33] <no_justification> Ummmmm. [14:37:33] <legoktm> 22:36:59 ['/srv/deployment/scap/scap/bin/scap', 'pull-master', 'tin.eqiad.wmnet'] on naos.codfw.wmnet returned : Could not chdir to home directory /var/lib/mwdeploy: No such file or directory [14:37:33] <legoktm> bash: /srv/deployment/scap/scap/bin/scap: No such file or directory [14:37:35] <no_justification> thcipriani: ^ [14:37:53] <thcipriani> also ummm [14:38:01] <legoktm> all of sync masters and canaries failed [14:38:13] <no_justification> /srv/deployment/scap/* shouldn't exist anymore in prod.... [14:38:28] <no_justification> I wonder if the patch file didn't get applied on deb package build? [14:38:29] <legoktm> the command I ran was [14:38:30] <legoktm> legoktm@tin:/srv/mediawiki-staging$ scap sync-file php-1.31.0-wmf.12/extensions/LoginNotify/includes/LoginNotify.php "Use extension registry to check for CheckUser to be installed - T182867" [14:38:31] <stashbot> T182867: "Login to Wikidata as QuickStatementsBot from a computer you have not recently used" - https://phabricator.wikimedia.org/T182867 [14:39:14] <thcipriani> yeah, if the quilt patches didn't get applied in the debian package... [14:40:24] <legoktm> was a new version deployed? [14:40:43] <thcipriani> this morning, yeah [14:41:00] <legoktm> was it tested afterwards? :p [14:41:29] <thcipriani> no :( [14:41:49] <thcipriani> so /usr/lib/python2.7/dist-packages/scap/config.py shows the wrong path to scap. That's applied via quilt. [14:42:05] <thcipriani> it should have been a redeploy of the same version that was running. [14:42:24] <thcipriani> except with a config flag that was missing.