Page MenuHomePhabricator

Duplicated reference section
Closed, ResolvedPublic1 Estimated Story Points

Description

Verbatim from https://www.mediawiki.org/wiki/Topic:U3xgtjz9atbhlm7x :

"When reviewing changes with "Visual (Beta)" I see a duplicated section of References, one at the bottom of the page and an empty one where the section should be."

See also https://en.wikipedia.org/w/index.php?title=Punavuori&type=revision&diff=815779756&oldid=749836503&visualdiff=&diffmode=visual .

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Deskana triaged this task as Medium priority.Dec 18 2017, 12:40 PM
Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
Deskana set the point value for this task to 1.

These aren't quite duplicates.

The reference lists get shown twice when inserted, because of a hack where we append the diffed references to the end of the diff. (When the reference list has changed but already existed this works.) Patch on its way.

T183536 should only occur in historical revision diffs, because there are "fake" differences in the historical diffs that aren't in the in-edit diff. Something to do with Parsoid changing the IDs - will need a separate fix.

Change 408227 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] WIP Show diffs for references lists in place

https://gerrit.wikimedia.org/r/408227

Change 408227 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Show diffs for references lists in place

https://gerrit.wikimedia.org/r/408227

Change 409968 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bf555de7e)

https://gerrit.wikimedia.org/r/409968

Change 409968 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bf555de7e)

https://gerrit.wikimedia.org/r/409968