Several commits missing from REL1_30 branch in PageForms extension
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	Thomas_Haselwanter
	Dec 18 2017, 9:46 AM

Description

Hi,
several commits checked in after September are missing from the REL_1_30 tagged source code. For example commit b093691bf79c8a011969c8e3453304a32b7266b1 by yaronkoren that fixes "Unicode error on Firefox, Chrome and Safari" is missing if one uses the "REL_1_30" to download the source code from Git.

Regards
Thomas

Details

	Subject	Repo	Branch	Lines +/-
	Fix for Unicode handling change in MW 1.30	mediawiki/extensions/PageForms	REL1_30	+4 -1

Customize query in gerrit

Related Objects

Mentioned In: rEPFMf3e6ec9b50f5: Fix for Unicode handling change in MW 1.30
Mentioned Here: rEPFMb093691bf79c: Fix for Unicode handling change in MW 1.30

Event Timeline

Thomas_Haselwanter created this task.Dec 18 2017, 9:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2017, 9:46 AM

Hi, in general, you shouldn't use any of the "REL" branches for Page Forms - they're just random snapshots in time, as you've noticed. The best option with Page Forms, assuming you're using a version of MediaWiki greater than 1.21, is just to get the latest code.

Marking this as "Invalid" - I have no coordination with the MediaWiki developers about setting these tags.

In T183120#3845505, @Yaron_Koren wrote:

Marking this as "Invalid" - I have no coordination with the MediaWiki developers about setting these tags.

You can backport commits to the branch yourself...

Change 398892 had a related patch set uploaded (by Legoktm; owner: Yaron Koren):
[mediawiki/extensions/PageForms@REL1_30] Fix for Unicode handling change in MW 1.30

https://gerrit.wikimedia.org/r/398892

gerritbot added a project: Patch-For-Review.Dec 18 2017, 6:39 PM

Legoktm renamed this task from Several commits missing from REL_1_30 tag to Several commits missing from REL1_30 tag.Dec 18 2017, 6:40 PM

Legoktm renamed this task from Several commits missing from REL1_30 tag to Several commits missing from REL1_30 branch in PageForms extension.

Legoktm mentioned this in rEPFMf3e6ec9b50f5: Fix for Unicode handling change in MW 1.30.Dec 18 2017, 6:41 PM

Change 398892 merged by Yaron Koren:
[mediawiki/extensions/PageForms@REL1_30] Fix for Unicode handling change in MW 1.30