Change copy on empty preview
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	ovasileva
	Dec 18 2017, 3:45 PM

Description

Background

After discussing the best way to handle previews when we have an error T182905: Show an informative preview when the backend service responds with an error, we decided the best option would be to change the copy on the original empty preview to handle all cases

empty preview:

Screen Shot 2017-12-19 at 6.23.33 PM.png (218×722 px, 55 KB)

Acceptance criteria

Change copy of empty preview to "There was an issue displaying this preview", link: change from "read" to "Go to this page", selecting link should navigate to the page
Ensure preview appears for all cases including when backend service responds with an error, i.e. the server responds with an HTTP 5xx code.

Testing instructions

Staging has been set up to load content from production and for Popups to use RESTBase [1]. When visiting a page in desktop and hovering over a preview you should see the old failure popup. The link in the popup will always link to Tracy Island. Ask a developer to update staging with the patches inside this task.
When the patches are live, you'll notice that the copy has changed and the link now points to the page relating to the link NOT the current page Tracy Island.
Ask a developer [2] to introduce a fatal error so that a 500 is triggered on a hover. Ensure the preview shows for this too.

Developer notes

[1] Config being used is:

$wgMFAlwaysUseMobileFormatter = true;
$wgPopupsGateway = "restbaseHTML";

[2] https://gerrit.wikimedia.org/r/#/c/403722/5 has some good instructions on how to simulate errors.

Details

Subject	Repo	Branch	Lines +/-
Update: show placeholder preview for more failures	mediawiki/extensions/Popups	master	+73 -26
Hygiene: add more fetch failure test cases	mediawiki/extensions/Popups	master	+48 -5
Update: missing preview copy	mediawiki/extensions/Popups	master	+14 -11
Fix: preview page URL for 404 RESTBase responses	mediawiki/extensions/Popups	master	+80 -58

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Dereckson	T68374 Enable Hovercards on se.wikimedia.org (Swedish chapter wiki)
Resolved	Jdlrobson	T70860 [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature
Resolved	ovasileva	T154635 [EPIC] Deploy page previews to English and German Wikipedia
Resolved	ovasileva	T183151 Change copy on empty preview

Event Timeline

ovasileva created this task.Dec 18 2017, 3:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2017, 3:45 PM

ovasileva triaged this task as High priority.Dec 18 2017, 3:45 PM

ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog board.

ovasileva mentioned this in T182905: Show an informative preview when the backend service responds with an error.

phuedx added a parent task: T70860: [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature.Dec 18 2017, 3:48 PM

ovasileva added a parent task: T154635: [EPIC] Deploy page previews to English and German Wikipedia.Dec 18 2017, 3:51 PM

ovasileva updated the task description. (Show Details)Dec 19 2017, 5:23 PM

ovasileva updated the task description. (Show Details)

ovasileva set the point value for this task to 3.Dec 19 2017, 5:29 PM

phuedx updated the task description. (Show Details)Jan 3 2018, 5:21 PM

We estimated this task a 3 because this looks like a copy change but will require that QA be able to set up an environment where the Page Previews client thinks that RESTBase is responding with HTTP 4xx, 5xx, and garbage responses.

We discussed possible approaches with @ABorbaWMF and they seemed happy with any/all of them.

@phuedx Yes, and I mentioned using staging in the meeting and we talked about using Fiddler or something similar, but I just realized we could probably run something on the beta cluster as well.

• Niedzielski claimed this task.Jan 4 2018, 8:30 PM

• Niedzielski added a project: Readers-Web-Kanbanana-Board-Old.

• Niedzielski moved this task from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.

ovasileva moved this task from Upcoming to 2017-18 Q2 on the Web-Team-Backlog board.Jan 8 2018, 6:11 PM

Change 403580 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[mediawiki/extensions/Popups@master] Fix: preview page URL for 404 RESTBase responses

https://gerrit.wikimedia.org/r/403580

gerritbot added a project: Patch-For-Review.Jan 11 2018, 3:31 AM

• Niedzielski removed a project: Patch-For-Review.Jan 11 2018, 3:32 AM

phuedx mentioned this in T170690: Extract a References JSON API.Jan 11 2018, 6:37 AM

Change 403683 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[mediawiki/extensions/Popups@master] Update: missing preview copy

https://gerrit.wikimedia.org/r/403683

Change 403684 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[mediawiki/extensions/Popups@master] Hygiene: add more fetch failure test cases

https://gerrit.wikimedia.org/r/403684

• Niedzielski removed a project: Patch-For-Review.Jan 11 2018, 3:46 PM

• Niedzielski moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jan 11 2018, 6:07 PM

Change 403722 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[mediawiki/extensions/Popups@master] Update: show placeholder preview for more failures

https://gerrit.wikimedia.org/r/403722

gerritbot added a project: Patch-For-Review.Jan 11 2018, 6:59 PM

Ready for review. Patchsets should be visited in the following order:

These changes all look sound, but my Popups is a little rusty so I'd appreciate a second glance. @Jhernandez maybe?

• Jhernandez moved this task from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.Jan 15 2018, 12:20 PM

• Niedzielski moved this task from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jan 17 2018, 6:09 PM

ovasileva moved this task from 2017-18 Q2 to 2017-18 Q3 on the Web-Team-Backlog board.Jan 17 2018, 6:44 PM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Jan 17 2018, 10:45 PM

Change 403580 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix: preview page URL for 404 RESTBase responses

https://gerrit.wikimedia.org/r/403580

Over to you @ABorbaWMF . Note that to test this, you'll need to seek help from a developer.

Jdlrobson updated the task description. (Show Details)Jan 17 2018, 10:50 PM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 17 2018, 11:00 PM

Change 403683 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Update: missing preview copy

https://gerrit.wikimedia.org/r/403683

Change 403684 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Hygiene: add more fetch failure test cases

https://gerrit.wikimedia.org/r/403684

Change 403722 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Update: show placeholder preview for more failures

https://gerrit.wikimedia.org/r/403722

Jdlrobson moved this task from Backlog to Next Up on the Page-Previews board.Jan 31 2018, 5:11 PM

This looks good to me on Staging

Screen Shot 2018-02-16 at 5.28.36 PM.png (1×2 px, 1 MB)

Screen Shot 2018-02-16 at 5.28.26 PM.png (1×2 px, 1 MB)

Screen Shot 2018-02-16 at 5.29.27 PM.png (1×2 px, 1 MB)

Screen Shot 2018-02-16 at 5.29.33 PM.png (1×2 px, 1 MB)

More browsers/OSs

Over to you, @ovasileva!

Looks good.

	F13812664: Screen Shot 2018-02-16 at 5.29.27 PM.png
	Feb 17 2018, 1:41 AM

	F13812665: Screen Shot 2018-02-16 at 5.29.33 PM.png
	Feb 17 2018, 1:41 AM

	F13812669: Screen Shot 2018-02-16 at 5.28.26 PM.png
	Feb 17 2018, 1:41 AM

	F13812668: Screen Shot 2018-02-16 at 5.28.36 PM.png
	Feb 17 2018, 1:41 AM

Change copy on empty previewClosed, ResolvedPublic3 Estimated Story PointsActions