Page MenuHomePhabricator

Patches in Gerrit deleting Selenium+Ruby tests for repositories that still have them
Closed, DeclinedPublic

Description

TODO

RepositoryTask/Commit
mediawiki/extensions/CentralAuthT173989
mediawiki/extensions/CentralNoticeT180223
mediawiki/extensions/GettingStartedT180224
mediawiki/extensions/MobileFrontendT177260
mediawiki/extensions/MultimediaViewerT180226
mediawiki/extensions/QuickSurveysT177261
mediawiki/extensions/RevisionSliderT180247
mediawiki/extensions/TwoColConflictT180248
mediawiki/extensions/WikibaseT180228
mediawiki/extensions/WikibaseLexemeT179916
mediawiki/skins/MinervaNeueT174018

I have cloned all repositories from Gerrit using a script I wrote. Results when I search for mediawiki_selenium in Gemfile.lock files.

$ ack --type-add=lock:ext:lock --lock mediawiki_selenium

mediawiki_extensions_CentralAuth/Gemfile.lock
41:    mediawiki_selenium (1.8.0)
108:  mediawiki_selenium (~> 1.8)

mediawiki_extensions_CentralNotice/Gemfile.lock
41:    mediawiki_selenium (1.8.0)
108:  mediawiki_selenium (~> 1.8)

mediawiki_extensions_GettingStarted/Gemfile.lock
41:    mediawiki_selenium (1.8.0)
108:  mediawiki_selenium (~> 1.8)

mediawiki_extensions_MobileFrontend/Gemfile.lock
42:    mediawiki_selenium (1.7.3)
108:  mediawiki_selenium (~> 1.7, >= 1.7.3)

mediawiki_extensions_MultimediaViewer/Gemfile.lock
41:    mediawiki_selenium (1.8.0)
108:  mediawiki_selenium (~> 1.8)

mediawiki_extensions_QuickSurveys/Gemfile.lock
41:    mediawiki_selenium (1.8.0)
108:  mediawiki_selenium (~> 1.8)

mediawiki_extensions_RevisionSlider/Gemfile.lock
41:    mediawiki_selenium (1.8.0)
108:  mediawiki_selenium (~> 1.8.0)

mediawiki_extensions_TwoColConflict/Gemfile.lock
41:    mediawiki_selenium (1.8.0)
109:  mediawiki_selenium (~> 1.8.0)

mediawiki_extensions_Wikibase/tests/browser/Gemfile.lock
47:    mediawiki_selenium (1.7.1)
123:  mediawiki_selenium (~> 1.7, >= 1.7.1)

mediawiki_extensions_WikibaseLexeme/Gemfile.lock
49:    mediawiki_selenium (1.7.1)
129:  mediawiki_selenium (~> 1.7, >= 1.7.1)

mediawiki_extensions_Wikidata/extensions/Wikibase/tests/browser/Gemfile.lock
46:    mediawiki_selenium (1.7.1)
117:  mediawiki_selenium (~> 1.7, >= 1.7.1)

mediawiki_skins_MinervaNeue/Gemfile.lock
42:    mediawiki_selenium (1.7.3)
108:  mediawiki_selenium (~> 1.7, >= 1.7.3)

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptDec 18 2017, 5:39 PM
zeljkofilipin triaged this task as Normal priority.Dec 18 2017, 5:39 PM
zeljkofilipin lowered the priority of this task from Normal to Low.Feb 27 2018, 3:15 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin closed this task as Declined.Sep 20 2018, 2:35 PM

I don't think this is a good idea any more. Until Selenium tests are moved from Ruby to JavaScript, it doesn't make much sense to delete Ruby tests. Some repositories have started the migration, some did not. See T139740: Port Selenium tests from Ruby to Node.js for status.