http://php.net/manual/en/aliases.php
For T173175 we decided upon is_int over is_integer. There's a lot more of these, and we should figure out which ones to autofix.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Expand sniff to replace some php aliases with main function | mediawiki/tools/codesniffer | master | +7 -2 |
Related Objects
Related Objects
- Mentioned Here
- T173175: Add sniff to prefer short is_int over is_integer
Event Timeline
Comment Actions
Change 402581 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/tools/codesniffer@master] Expand sniff to replace some php aliases with main function
Comment Actions
Change 402581 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Expand sniff to replace some php aliases with main function
Comment Actions
Added:
- is_writeable => is_writable
- join => implode
- key_exists => array_key_exists
- pos => current
- sizeof => count
There are still some on the list under the url.
I am not sure, if it makes sense for the is_long, is_double and so on to be part of the sniff.
Feel free to close, if all is done or upload a follow up.