Blacklisted links should mean the page can't be saved
OpenPublic

Description

Author: mike.lifeguard+bugs

Description:
Basically, this is a request to undo r34769 (T3505: Spam blacklist, if match, check previous version and accept if URL present there).

Allowing blacklisted links to remain in the page is bad for a few reasons:

Concerns about reverting vandalism (T3505#56358) are valid, and should be addressed; see T17450: Rollback should be unaffected by the spam blacklist to make *rollback* (only) exempt.

See Also:

bzimport added a subscriber: wikibugs-l.
bzimport set Reference to bz16325.
bzimport created this task.Via LegacyNov 13 2008, 3:51 AM
bzimport added a comment.Via ConduitNov 13 2008, 3:54 AM

cbm.wikipedia wrote:

One issue with this is that if page A transcludes page B, and B trips the spam filter, then saving A will fail. To make this less bad, the spam filter should be put deeper into the parser code, so that as soon as B is parsed the spam filter is checked against it. That would allow a more detailed error message - that page A cannot be saved because page B trips the spam filter with a certain link.

bzimport added a comment.Via ConduitNov 13 2008, 3:55 AM

mike.lifeguard+bugs wrote:

(In reply to comment #1)

One issue with this is that if page A transcludes page B, and B trips the spam
filter, then saving A will fail. To make this less bad, the spam filter should
be put deeper into the parser code, so that as soon as B is parsed the spam
filter is checked against it. That would allow a more detailed error message -
that page A cannot be saved because page B trips the spam filter with a certain
link.

That would require a more thorough rewrite, I think, and should therefore be requested separately. This might conceivably be done at the same time as bug 4459.

Peachey88 added a comment.Via ConduitSep 12 2011, 5:48 AM

Isn't this how it works now? I'm sure i've seen issues with bots on en.wiki because they are failing when their is blacklisted links on the page.

He7d3r edited the task description. (Show Details)Via WebTue, Apr 28, 10:27 AM
He7d3r set Security to None.

Add Comment