Page MenuHomePhabricator
Create Task
Maniphest T183265

Write operations should fail on connections to database replicas.
Closed, ResolvedPublic
Actions

Description

MediaWiki should catch any attempts to write to a database replica.
This addresses part of the requirement of T183242.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Test for writes being prevented on replica connections.mediawiki/coremaster+37 -6
Set CONN_NO_WRITE on all relevant code paths in LoadBalancer.mediawiki/coremaster+39 -8
Follow-up 36f4daf32c: allow no-write database connections to use transactionsmediawiki/coremaster+0 -15
Prevent write operations to database replicas.mediawiki/coremaster+60 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Dec 19 2017, 3:44 PM
daniel triaged this task as Medium priority.
daniel removed a parent task: T183244: Unit tests should fail when code writes to a DB connection obtained with the DB_REPLICA flag..Dec 19 2017, 3:46 PM
Addshore awarded a token.Dec 19 2017, 3:46 PM
Addshore moved this task from Inbox to Done on the Multi-Content-Revisions board.
daniel renamed this task from Write operations should fail on connections obtained for the DB_REPLICA index, even if there is only one database. to Write operations should fail on connections to database replicas..Dec 19 2017, 3:47 PM
daniel updated the task description. (Show Details)
daniel added a parent task: T183242: DB handles obtained with DB_REPLICA should not allow writes.
daniel raised the priority of this task from Medium to High.Dec 19 2017, 3:51 PM
daniel mentioned this in T183242: DB handles obtained with DB_REPLICA should not allow writes.
gerritbot subscribed.Dec 19 2017, 4:11 PM

Change 399208 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Prevent write operations to database replicas.

https://gerrit.wikimedia.org/r/399208

gerritbot added a project: Patch-For-Review.Dec 19 2017, 4:11 PM
daniel added subscribers: aaron, tstarling.Dec 19 2017, 4:13 PM
gerritbot added a comment.Dec 19 2017, 4:44 PM

Change 399208 merged by jenkins-bot:
[mediawiki/core@master] Prevent write operations to database replicas.

https://gerrit.wikimedia.org/r/399208

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 19 2017, 5:00 PM
gerritbot added a comment.Dec 20 2017, 2:28 PM

Change 399404 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Follow-up 36f4daf32c: allow no-write database connections to use transactions

https://gerrit.wikimedia.org/r/399404

gerritbot added a comment.Dec 20 2017, 4:02 PM

Change 399404 merged by jenkins-bot:
[mediawiki/core@master] Follow-up 36f4daf32c: allow no-write database connections to use transactions

https://gerrit.wikimedia.org/r/399404

gerritbot added a comment.Dec 20 2017, 6:38 PM

Change 399447 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Set CONN_NO_WRITE on all relevant code pathes in LoadBalancer.

https://gerrit.wikimedia.org/r/399447

Catrope mentioned this in T183252: Unbreak replication in beta cluster.Dec 21 2017, 11:23 AM
gerritbot added a comment.Dec 21 2017, 11:28 AM

Change 399447 abandoned by Daniel Kinzler:
Set CONN_NO_WRITE on all relevant code paths in LoadBalancer.

Reason:
Superseded by Ie8205749b14

https://gerrit.wikimedia.org/r/399447

gerritbot added a comment.Dec 21 2017, 11:34 AM

Change 399604 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Test for writes being prevented on replica connections.

https://gerrit.wikimedia.org/r/399604

gerritbot added a comment.Dec 21 2017, 11:54 AM

Change 399604 merged by jenkins-bot:
[mediawiki/core@master] Test for writes being prevented on replica connections.

https://gerrit.wikimedia.org/r/399604

daniel closed this task as Resolved.Dec 21 2017, 2:36 PM
TK-999 mentioned this in T259362: Permit temporary table operations to be executed on replica connections.Jul 31 2020, 3:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits