Page MenuHomePhabricator

Write operations should fail on connections to database replicas.
Closed, ResolvedPublic

Description

MediaWiki should catch any attempts to write to a database replica.
This addresses part of the requirement of T183242.

Event Timeline

daniel triaged this task as Medium priority.Dec 19 2017, 3:44 PM
daniel created this task.
Addshore moved this task from Inbox to Done on the Multi-Content-Revisions board.
daniel renamed this task from Write operations should fail on connections obtained for the DB_REPLICA index, even if there is only one database. to Write operations should fail on connections to database replicas..Dec 19 2017, 3:47 PM
daniel updated the task description. (Show Details)
daniel raised the priority of this task from Medium to High.Dec 19 2017, 3:51 PM

Change 399208 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Prevent write operations to database replicas.

https://gerrit.wikimedia.org/r/399208

Change 399208 merged by jenkins-bot:
[mediawiki/core@master] Prevent write operations to database replicas.

https://gerrit.wikimedia.org/r/399208

Change 399404 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Follow-up 36f4daf32c: allow no-write database connections to use transactions

https://gerrit.wikimedia.org/r/399404

Change 399404 merged by jenkins-bot:
[mediawiki/core@master] Follow-up 36f4daf32c: allow no-write database connections to use transactions

https://gerrit.wikimedia.org/r/399404

Change 399447 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Set CONN_NO_WRITE on all relevant code pathes in LoadBalancer.

https://gerrit.wikimedia.org/r/399447

Change 399447 abandoned by Daniel Kinzler:
Set CONN_NO_WRITE on all relevant code paths in LoadBalancer.

Reason:
Superseded by Ie8205749b14

https://gerrit.wikimedia.org/r/399447

Change 399604 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Test for writes being prevented on replica connections.

https://gerrit.wikimedia.org/r/399604

Change 399604 merged by jenkins-bot:
[mediawiki/core@master] Test for writes being prevented on replica connections.

https://gerrit.wikimedia.org/r/399604

daniel closed this task as Resolved.Dec 21 2017, 2:36 PM