Page MenuHomePhabricator
Create Task
Maniphest T183299

Replace and deprecate CapsuleMultiselectWidget
Closed, ResolvedPublic
Actions

Description

With v0.21.0 TagMultiselectWidget has been integrated into OOUI and since then, it has been proven its stability while being used successfully in prominent places like RCFilters and AdvancedSearch.
As a consequence, let's replace, deprecate and finally remove inferior CapsuleMultiselectWidget from OOUI. It would also improve situation for newcomers who need to decide what they are going for and having presented two mostly similar widgets.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2017, 9:52 PM
Volker_E added a parent task: T158400: Streamline & improve tag component TagMultiselectWidget (former CapsuleMultiselectWidget).Dec 19 2017, 10:11 PM
Volker_E mentioned this in T108491: Let you specify that a TagMultiselectWidget has a fixed order.Dec 19 2017, 10:27 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Dec 20 2017, 2:06 AM
Volker_E updated the task description. (Show Details)
gerritbot subscribed.Dec 20 2017, 3:51 PM

Change 399427 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Use new TagMultiselectWidget in ApiSandbox

https://gerrit.wikimedia.org/r/399427

gerritbot added a project: Patch-For-Review.Dec 20 2017, 3:51 PM
Anomie added a comment.Dec 20 2017, 4:01 PM

In the course of updating ApiSandbox, I found two regressions.

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Jan 29 2018, 5:40 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 31 2018, 11:37 PM
Anomie updated the task description. (Show Details)Feb 1 2018, 2:19 PM
matmarex added subtasks: T183377: MenuTagMultiselectWidget menu doesn't close properly when used with an overlay, T183378: MenuTagMultiselectWidget does not clear the input field when selecting a tag from the menu.Feb 2 2018, 1:51 AM
matmarex merged tasks: T169291: Replace CapsuleMultiselectWidget usage with TagMultiselectWidgets, T169292: Deprecate & remove CapsuleMultiselectWidget.Feb 2 2018, 2:30 AM
matmarex added a subscriber: • santhosh.
Volker_E closed subtask T183378: MenuTagMultiselectWidget does not clear the input field when selecting a tag from the menu as Resolved.Feb 6 2018, 10:27 PM
matmarex removed a project: Patch-For-Review.Feb 7 2018, 1:59 AM
matmarex updated the task description. (Show Details)
gerritbot added a comment.Feb 7 2018, 2:06 AM

Change 399427 merged by jenkins-bot:
[mediawiki/core@master] Use new TagMultiselectWidget in ApiSandbox

https://gerrit.wikimedia.org/r/399427

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 7 2018, 3:00 AM
Anomie unsubscribed.Feb 7 2018, 3:09 PM
gerritbot added a comment.Mar 1 2018, 7:09 AM

Change 415525 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] multiselect: Use MenuTagMultiselectWidget

https://gerrit.wikimedia.org/r/415525

gerritbot added a project: Patch-For-Review.Mar 1 2018, 7:09 AM
gerritbot added a comment.Mar 1 2018, 8:04 PM

Change 415525 merged by jenkins-bot:
[mediawiki/core@master] multiselect: Use MenuTagMultiselectWidget

https://gerrit.wikimedia.org/r/415525

matmarex removed a project: Patch-For-Review.Mar 1 2018, 9:21 PM
matmarex updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Mar 1 2018, 9:25 PM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)); removed MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Mar 6 2018, 12:01 PM
gerritbot added a comment.Mar 8 2018, 6:09 AM

Change 417193 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[oojs/ui@master] TagMultiselectWidget: Abort addTag if createTagItemWidget returns null

https://gerrit.wikimedia.org/r/417193

gerritbot added a project: Patch-For-Review.Mar 8 2018, 6:09 AM

Change 417194 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] [WIP] mw.widgets.CategoryMultiselectWidget use TagMultiselectWidget

https://gerrit.wikimedia.org/r/417194

gerritbot added a comment.Mar 9 2018, 6:33 AM

Change 417193 abandoned by Prtksxna:
TagMultiselectWidget: Abort addTag if createTagItemWidget returns null

Reason:
I am sorry. I jumped the gun here. The problem I was facing was somewhere else.

See:
https://phabricator.wikimedia.org/T189282
Ia0732faff2d98f1ca07da5fbe1f2abc27f71a617

https://gerrit.wikimedia.org/r/417193

Volker_E closed subtask T189282: MenuTagMultiselectWidget (allowArbitrary) allows you to add one empty tag as Resolved.Mar 9 2018, 10:42 PM
• Prtksxna mentioned this in T189282: MenuTagMultiselectWidget (allowArbitrary) allows you to add one empty tag.Mar 29 2018, 10:08 AM
• Prtksxna added a comment.Apr 9 2018, 5:34 AM
From the description:
  • Extension UploadWizard: CategoriesDetailsWidget extends CapsuleMultiselectWidget

uw.CategoriesDetailsWidget uses mw.widgets.CategoryMultiselectWidget and thankfully doesn't extend it. If I understand correctly, this one should get resolved with rMW4cc9dd16ee15: mw.widgets.CategoryMultiselectWidget use TagMultiselectWidget.

• Prtksxna added a comment.Apr 9 2018, 5:46 AM
From the description:
  • Extension VisualEditor: CapsuleMultiselectWidget for categories

Doesn't VE still use the completely separate ve.ui.MWCategoryWidget?
See T147811: Unify mw.widgets.CategorySelector and ve.ui.MWCategoryWidget.

Aklapper added a project: Technical-Debt.Apr 9 2018, 6:35 AM
Volker_E mentioned this in T193389: Tab-key should select first entry in autosuggest dropdown.May 20 2018, 12:25 PM
Volker_E updated the task description. (Show Details)
Volker_E added subscribers: • Tonina_Zhelyazkova_WMDE, gabriel-wmde.
• Tonina_Zhelyazkova_WMDE mentioned this in T195177: Use TagMultiSelectWidget for category input field..May 20 2018, 12:29 PM
Volker_E mentioned this in T108489: Generalise CapsuleMultiselectWidget and CheckboxMultiselectWidget into a MultiselectWidget.May 29 2018, 10:49 AM
Volker_E triaged this task as High priority.Jun 13 2018, 2:20 PM
gabriel-wmde added a comment.Jun 13 2018, 2:35 PM

If you feel like it, you can have a look at what we're doing in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AdvancedSearch/+/439916/ There we have an abstracted widget that will hopefully look and work similar to CategoryMultiselectWidget but also be able to do the same work for any namespace (e.g. Templates). Feel free to copy code and/or make suggestions to improve it.

For AdvancedSearch, we're omitting the progress spinner while looking up the existence of pages (to make the field allow arbitrary input).

Volker_E updated the task description. (Show Details)Jun 27 2018, 7:52 AM
Volker_E added a subscriber: Esanders.Jun 27 2018, 7:55 AM

@Esanders Insights on the VE side of this? See @Prtksxna's comment above.

• Prtksxna updated the task description. (Show Details)Jun 27 2018, 7:57 AM
• Prtksxna updated the task description. (Show Details)
gerritbot added a comment.Jun 27 2018, 8:19 AM

Change 417194 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.CategoryMultiselectWidget use TagMultiselectWidget

https://gerrit.wikimedia.org/r/417194

matmarex updated the task description. (Show Details)Jun 27 2018, 9:19 PM
In T183299#4115642, @Prtksxna wrote:
From the description:
  • Extension VisualEditor: CapsuleMultiselectWidget for categories

Doesn't VE still use the completely separate ve.ui.MWCategoryWidget?
See T147811: Unify mw.widgets.CategorySelector and ve.ui.MWCategoryWidget.

In T183299#4318234, @Volker_E wrote:

@Esanders Insights on the VE side of this? See @Prtksxna's comment above.

Yes, VE uses a different widget. I removed it from the task description.

gerritbot added a comment.Jun 28 2018, 7:37 AM

Change 442782 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/UploadWizard@master] CategoriesDetailsWidget: Stop using methods from CapsuleMultiselectWidget

https://gerrit.wikimedia.org/r/442782

gerritbot added a comment.Jun 28 2018, 7:38 AM

Change 442784 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] ForeignStructuredUpload: Stop using methods from CapsuleMultiselectWidget

https://gerrit.wikimedia.org/r/442784

gerritbot added a comment.Jun 28 2018, 7:47 AM

Change 442786 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] RELEASE-NOTES: Add note for breaking CategoryMultiselectWidget

https://gerrit.wikimedia.org/r/442786

gerritbot added a comment.Jun 28 2018, 1:06 PM

Change 442786 merged by jenkins-bot:
[mediawiki/core@master] RELEASE-NOTES: Add note for breaking CategoryMultiselectWidget

https://gerrit.wikimedia.org/r/442786

Volker_E updated the task description. (Show Details)Jun 28 2018, 1:11 PM
gerritbot added a comment.Jun 29 2018, 1:52 AM

Change 442784 merged by Krinkle:
[mediawiki/core@master] ForeignStructuredUpload: Stop using methods from CapsuleMultiselectWidget

https://gerrit.wikimedia.org/r/442784

Volker_E updated the task description. (Show Details)Jun 29 2018, 3:19 PM
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subtask: T188886: TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused.
gerritbot added a comment.Jun 29 2018, 3:52 PM

Change 443107 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [DEPRECATING CHANGE] CapsuleMultiselectWidget: Deprecate widget

https://gerrit.wikimedia.org/r/443107

gerritbot added a project: Patch-For-Review.Jun 29 2018, 3:52 PM
Volker_E updated the task description. (Show Details)Jun 29 2018, 4:11 PM
gerritbot added a comment.Jun 29 2018, 8:08 PM

Change 442782 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] CategoriesDetailsWidget: Stop using methods from CapsuleMultiselectWidget

https://gerrit.wikimedia.org/r/442782

gerritbot added a comment.Jun 29 2018, 9:13 PM

Change 443107 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] CapsuleMultiselectWidget: Deprecate widget

https://gerrit.wikimedia.org/r/443107

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 6:01 PM
Volker_E removed a project: Patch-For-Review.Jul 16 2018, 3:55 PM
Volker_E updated the task description. (Show Details)
Volker_E moved this task from Reviewing to Waiting for breaking release on the OOUI board.
Volker_E removed a subscriber: gerritbot.
gerritbot added a comment.Oct 2 2018, 12:16 AM

Change 463872 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[oojs/ui@master] [BREAKING CHANGE] Drop CapsuleMultiselectWidget, deprecated since v0.27.5

https://gerrit.wikimedia.org/r/463872

gerritbot added a project: Patch-For-Review.Oct 2 2018, 12:16 AM
gerritbot added a comment.Oct 2 2018, 12:42 AM

Change 463872 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] Drop CapsuleMultiselectWidget, deprecated since v0.27.5

https://gerrit.wikimedia.org/r/463872

Volker_E moved this task from Waiting for breaking release to OOUI-0.29.0 on the OOUI board.Oct 2 2018, 12:44 AM
Volker_E edited projects, added OOUI (OOUI-0.29.0); removed OOUI.
Volker_E added a comment.Oct 3 2018, 5:48 AM

A minor, yet exciting detail of this (exemplified on WikimediaUI theme – oojs-ui-widgets-wikimediaui.css minified “original size” and gzipped “result size”):

v0.28.2v0.29.0
Original size: 36484 bytes Result size: 4339 bytesOriginal size: 30168 bytes Result size: 3981 bytes

Or around 8% file size reduction minified/gzipped of render blocking CSS.

Volker_E closed this task as Resolved.Oct 3 2018, 5:54 AM
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
Volker_E awarded a token.
gerritbot added a comment.Oct 3 2018, 5:31 PM

Change 464370 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.29.0

https://gerrit.wikimedia.org/r/464370

gerritbot added a project: Patch-For-Review.Oct 3 2018, 5:31 PM
Volker_E removed a project: Patch-For-Review.Oct 3 2018, 5:37 PM
gerritbot added a comment.Oct 4 2018, 5:14 PM

Change 464607 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.1

https://gerrit.wikimedia.org/r/464607

gerritbot added a project: Patch-For-Review.Oct 4 2018, 5:14 PM

Change 464370 abandoned by Jforrester:
Update OOUI to v0.29.0

Reason:
Replaced by Ie847465af6762.

https://gerrit.wikimedia.org/r/464370

gerritbot added a comment.Oct 4 2018, 6:31 PM

Change 464607 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.1

https://gerrit.wikimedia.org/r/464607

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)); removed Patch-For-Review, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Oct 4 2018, 7:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL