Page MenuHomePhabricator

Error with Dynamic Page List and rendering content after upgrading to 1.30.0
Open, HighPublic

Description

[e745cffe6352b163b5aeb966] /wiki/Navigator%27s_Dagger Error from line 79 of /var/www/ffxiv.gamerescape.com/htdocs/w/extensions/DynamicPageList/DPL.php: Cannot access private property Cite::$mGroupCnt
Backtrace:
#0 /var/www/ffxiv.gamerescape.com/htdocs/w/extensions/DynamicPageList/DPLMain.php(3151): DPL->__construct(array, boolean, integer, integer, integer, string, array, string, DPLListMode, DPLListMode, string, boolean, boolean, NULL, array, array, array, boolean, Parser, DPLLogger, array, NULL, string, array, boolean, string, string, string)
#1 /var/www/ffxiv.gamerescape.com/htdocs/w/extensions/DynamicPageList/DPLSetup.php(1379): DPLMain::dynamicPageList(string, array, Parser, array, string)
#2 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3383): ExtDynamicPageList::dplParserFunction(Parser, string, string, string, string, string, string, string, string)
#3 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3106): Parser->callParserFunction(PPTemplateFrame_DOM, string, array)
#4 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Preprocessor_DOM.php(1229): Parser->braceSubstitution(array, PPTemplateFrame_DOM)
#5 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3262): PPFrame_DOM->expand(DOMElement)
#6 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Preprocessor_DOM.php(1229): Parser->braceSubstitution(array, PPTemplateFrame_DOM)
#7 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3374): PPFrame_DOM->expand(DOMElement)
#8 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3106): Parser->callParserFunction(PPTemplateFrame_DOM, string, array)
#9 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Preprocessor_DOM.php(1229): Parser->braceSubstitution(array, PPTemplateFrame_DOM)
#10 /var/www/ffxiv.gamerescape.com/htdocs/w/extensions/ParserFunctions/ParserFunctions_body.php(106): PPFrame_DOM->expand(DOMElement)
#11 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3383): ExtParserFunctions::ifObj(Parser, PPTemplateFrame_DOM, array)
#12 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3106): Parser->callParserFunction(PPTemplateFrame_DOM, string, array)
#13 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Preprocessor_DOM.php(1229): Parser->braceSubstitution(array, PPTemplateFrame_DOM)
#14 /var/www/ffxiv.gamerescape.com/htdocs/w/extensions/ParserFunctions/ParserFunctions_body.php(106): PPFrame_DOM->expand(DOMElement)
#15 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3383): ExtParserFunctions::ifObj(Parser, PPTemplateFrame_DOM, array)
#16 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3106): Parser->callParserFunction(PPTemplateFrame_DOM, string, array)
#17 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Preprocessor_DOM.php(1229): Parser->braceSubstitution(array, PPTemplateFrame_DOM)
#18 /var/www/ffxiv.gamerescape.com/htdocs/w/extensions/ParserFunctions/ParserFunctions_body.php(106): PPFrame_DOM->expand(DOMElement)
#19 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3383): ExtParserFunctions::ifObj(Parser, PPTemplateFrame_DOM, array)
#20 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3106): Parser->callParserFunction(PPTemplateFrame_DOM, string, array)
#21 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Preprocessor_DOM.php(1229): Parser->braceSubstitution(array, PPTemplateFrame_DOM)
#22 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3262): PPFrame_DOM->expand(DOMElement)
#23 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Preprocessor_DOM.php(1229): Parser->braceSubstitution(array, PPTemplateFrame_DOM)
#24 /var/www/ffxiv.gamerescape.com/htdocs/w/extensions/ParserFunctions/ParserFunctions_body.php(104): PPFrame_DOM->expand(DOMElement)
#25 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3383): ExtParserFunctions::ifObj(Parser, PPTemplateFrame_DOM, array)
#26 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3106): Parser->callParserFunction(PPTemplateFrame_DOM, string, array)
#27 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Preprocessor_DOM.php(1229): Parser->braceSubstitution(array, PPTemplateFrame_DOM)
#28 /var/www/ffxiv.gamerescape.com/htdocs/w/extensions/ParserFunctions/ParserFunctions_body.php(104): PPFrame_DOM->expand(DOMElement)
#29 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3383): ExtParserFunctions::ifObj(Parser, PPTemplateFrame_DOM, array)
#30 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3106): Parser->callParserFunction(PPTemplateFrame_DOM, string, array)
#31 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Preprocessor_DOM.php(1229): Parser->braceSubstitution(array, PPTemplateFrame_DOM)
#32 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(3262): PPFrame_DOM->expand(DOMElement)
#33 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Preprocessor_DOM.php(1229): Parser->braceSubstitution(array, PPFrame_DOM)
#34 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(2921): PPFrame_DOM->expand(DOMElement, integer)
#35 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(1277): Parser->replaceVariables(string)
#36 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/parser/Parser.php(451): Parser->internalParse(string)
#37 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/content/WikitextContent.php(329): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#38 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/content/AbstractContent.php(516): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#39 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/poolcounter/PoolWorkArticleView.php(144): AbstractContent->getParserOutput(Title, integer, ParserOptions)
#40 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/poolcounter/PoolCounterWork.php(123): PoolWorkArticleView->doWork()
#41 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/page/Article.php(585): PoolCounterWork->execute()
#42 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/actions/ViewAction.php(68): Article->view()
#43 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/MediaWiki.php(499): ViewAction->show()
#44 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/MediaWiki.php(293): MediaWiki->performAction(Article, Title)
#45 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/MediaWiki.php(851): MediaWiki->performRequest()
#46 /var/www/ffxiv.gamerescape.com/htdocs/w/includes/MediaWiki.php(523): MediaWiki->main()
#47 /var/www/ffxiv.gamerescape.com/htdocs/w/index.php(43): MediaWiki->run()
#48 {main}

Event Timeline

charitwo created this task.Dec 20 2017, 1:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2017, 1:02 AM
charitwo triaged this task as Unbreak Now! priority.Dec 20 2017, 1:03 AM
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptDec 20 2017, 1:03 AM
Reedy added a subscriber: Reedy.Dec 20 2017, 1:16 AM

Caused by https://gerrit.wikimedia.org/r/#/c/311963/3 which is in REL1_29 of Cite...

Aklapper added a subscriber: thiemowmde.

Change 399412 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/DynamicPageList@master] Disable hooks instead of accessing private Cite properties

https://gerrit.wikimedia.org/r/399412

greg lowered the priority of this task from Unbreak Now! to High.Dec 21 2017, 12:03 AM
greg added a subscriber: greg.

(Did this cause data loss? Is it on WMF production? I think the answers are "no", right? resetting priority UBN!->High. Still important.)

Izno moved this task from Unsorted backlog to Defect backlog on the Cite board.Dec 31 2017, 8:36 PM

Change 399412 merged by jenkins-bot:
[mediawiki/extensions/DynamicPageList@master] Disable hooks instead of accessing private Cite properties

https://gerrit.wikimedia.org/r/399412

Change 414161 had a related patch set uploaded (by Legoktm; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/DynamicPageList@REL1_30] Disable hooks instead of accessing private Cite properties

https://gerrit.wikimedia.org/r/414161

Change 414161 merged by jenkins-bot:
[mediawiki/extensions/DynamicPageList@REL1_30] Disable hooks instead of accessing private Cite properties

https://gerrit.wikimedia.org/r/414161