Maniphest T183360

Exception thrown when opening VE help dialog
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Esanders
	Dec 20 2017, 1:20 PM

Tags

Referenced Files

None

Subscribers

Description

Open Flow, press CTRL+/.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix editor switcher inheritance	mediawiki/extensions/Flow	master	+33 -4

Customize query in gerrit

Related Objects

Mentioned Here: T184665: [betalabs] "Uncaught TypeError: this.isFloatableOutOfView is not a function" when clicking on "Switch editor"

Event Timeline

Esanders created this task.Dec 20 2017, 1:20 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 20 2017, 1:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 399394 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Flow@master] Fix editor switcher inheritance

https://gerrit.wikimedia.org/r/399394

gerritbot added a project: Patch-For-Review.Dec 20 2017, 1:21 PM

That's a "That was working before" bug.

Change 399394 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Fix editor switcher inheritance

https://gerrit.wikimedia.org/r/399394

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 20 2017, 3:00 PM

Catrope edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Patch-For-Review, Collaboration-Team-Triage.Jan 9 2018, 7:35 PM

Catrope moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Checked in wmf.15/16 - no exception from CTRL+/ (checked both pages and SD pages).

However, in betalabs I got the Console error when clicking on the VE switch - I filed it as a separate ticket - T184665: [betalabs] "Uncaught TypeError: this.isFloatableOutOfView is not a function" when clicking on "Switch editor"

Etonkovidova closed this task as Resolved.Jan 11 2018, 12:16 AM