Description

When a user wants to save the resolution page, but did not select all versions of the conflict,

give a meaningful error message.

For details see mocks:
Case: User has not yet clicked on save.

Case: User clicked on save button, but had not selected all versions before

If "Please choose a version" is above the box, the rectangle is around it, too.
The first version does not include the scroll-to-message.

Remove the disabled save button we have right now

Details

	Subject	Repo	Branch	Lines +/-
	[WIP] Show error message in prototype if not all versions have been selected	mediawiki/extensions/TwoColConflict	master	+101 -24

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T72163 Edit conflicts (tracking)
Resolved	None	T139601 Better solutions to edit conflicts (#1)
Resolved	Lea_WMDE	T180972 Create prototype for new edit conflict merge approach
Resolved	Andrew-WMDE	T183363 Show error message in prototype if not all versions have been selected

Event Timeline

Lea_WMDE created this task.Dec 20 2017, 1:25 PM

Restricted Application added projects: TCB-Team (now WMDE-TechWish), Design. · View Herald TranscriptDec 20 2017, 1:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Hanna_Petruschat_WMDE claimed this task.Jan 8 2018, 3:48 PM

• Hanna_Petruschat_WMDE moved this task from Incoming to Incoming WD on the WMDE-Design board.

• Hanna_Petruschat_WMDE moved this task from Incoming WD to WMDE-Design-Workboard Doing on the WMDE-Design board.Jan 8 2018, 4:01 PM

• Hanna_Petruschat_WMDE edited projects, added WMDE-Design (WMDE-Design-Workboard Doing); removed WMDE-Design.

• Hanna_Petruschat_WMDE moved this task from ToDo to doing on the WMDE-Design (WMDE-Design-Workboard Doing) board.Jan 8 2018, 4:04 PM

I have two solutions for this. Some notes on this:
I would only recommend the greyed out save-button if we have a permanent info in red underneath, so the user can immediately see what's missing AND can also click to have missing paragraphs highlighted. If this is not possible I would go for the save-button which is clickable and then shows a warning plus the highlighted paragraphs.

Regarding the highlighting of the paragraphs I would also go for the "in-your-face"-version (the one with a red rectangle behind boths versions) if that's possible to implement because warnings should be easily visible.

greyed out save-button with decent highlighting:

clickable save-button with very visible highlighting:

Another attemp (not needed for the MVP but still shown) is to further highlight the selected version with an upgrading of the saturation of the frame.

• Hanna_Petruschat_WMDE moved this task from doing to done on the WMDE-Design (WMDE-Design-Workboard Doing) board.Jan 8 2018, 5:52 PM

Lea_WMDE triaged this task as Medium priority.Jan 9 2018, 10:46 AM

Lea_WMDE updated the task description. (Show Details)

• Hanna_Petruschat_WMDE removed projects: WMDE-Design (WMDE-Design-Workboard Doing), Design.Jan 15 2018, 2:52 PM

Lea_WMDE moved this task from Backlog to TwoColConflict revamping spike on the Two-Column-Edit-Conflict-Merge board.Jan 16 2018, 10:48 AM

Lea_WMDE updated the task description. (Show Details)Jan 16 2018, 3:46 PM

Lea_WMDE set the point value for this task to 3.

Change 405730 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/TwoColConflict@master] [WIP] Show error message in prototype if not all versions have been selected

https://gerrit.wikimedia.org/r/405730

gerritbot added a project: Patch-For-Review.Jan 22 2018, 4:01 PM

Andrew-WMDE mentioned this in rESCC6ba0babf81d3: [WIP] Show error message in prototype if not all versions have been selected.Jan 22 2018, 4:03 PM

Lea_WMDE added a project: WMDE-TechWish.Jan 22 2018, 7:55 PM

Lea_WMDE moved this task from Proposed to Sprint ready on the WMDE-TechWish board.

WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2018-01-23.Jan 23 2018, 3:59 PM

WMDE-Fisch reassigned this task from • Hanna_Petruschat_WMDE to Andrew-WMDE.Jan 23 2018, 4:07 PM

WMDE-Fisch moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-01-23 board.

WMDE-Fisch added a subscriber: • Hanna_Petruschat_WMDE.

Lea_WMDE added a parent task: T180972: Create prototype for new edit conflict merge approach.Feb 1 2018, 10:32 AM

Andrew-WMDE mentioned this in rESCCd2f74d301ca8: [WIP] Show error message in prototype if not all versions have been selected.Feb 5 2018, 12:04 PM

WMDE-Fisch mentioned this in rESCCe90b11b14e7e: [WIP] Show error message in prototype if not all versions have been selected.Feb 5 2018, 2:29 PM

Andrew-WMDE closed this task as Resolved.Feb 6 2018, 3:26 PM

Andrew-WMDE moved this task from Review to Done on the WMDE-QWERTY-Sprint-2018-01-23 board.

Addshore mentioned this in rESCC11556e09a1e1: [WIP] Show error message in prototype if not all versions have been selected.Feb 9 2018, 12:15 PM

Tobi_WMDE_SW moved this task from Sprint ready to Done on the WMDE-TechWish board.Feb 20 2018, 3:19 PM

Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Feb 20 2018, 4:48 PM

Change 405730 abandoned by WMDE-Fisch:
[WIP] Show error message in prototype if not all versions have been selected

Reason:
Squashed in
I267de58c2a3f965b8eebfb545e6b417601527191

https://gerrit.wikimedia.org/r/405730

	F12322786: MVP 2.1.jpg
	Jan 8 2018, 5:52 PM

	F12322767: MVP 1.2.jpg
	Jan 8 2018, 5:52 PM

	F12322763: MVP 1.1.jpg
	Jan 8 2018, 5:52 PM

	F12322787: MVP 2.2.jpg
	Jan 8 2018, 5:52 PM

Show error message in prototype if not all versions have been selectedClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

Show error message in prototype if not all versions have been selected
Closed, ResolvedPublic3 Estimated Story Points
Actions

Related Objects
Search...