Secondary links in Echo are now broken in monobook:
This doesn't happen in Vector, and it still happens regardless of the popup being in or out of an overlay (see https://gerrit.wikimedia.org/r/#/c/399536/ that moves the popup to an overlay outside the <li>)
I suspect there's an issue with MenuOptionWidget's design in Apex.
| mediawiki/extensions/Echo : master | mw.echo.ui.MenuItemWidget: Override OOUI styles harder |
@Volker_E I played around with trying to fix it, but all the adjustments don't make much sense (making the icon display:inline-block; but then reducing margin and re-aligning the label... pit of despair, that approach)
Can you take a look? We are overriding a couple of OOUI definitions, but they're only with the icon size so they shouldn't affect anything like this. Also, these are affecting Vector (MediawikiUI) without breaking this behavior.
There is a position: absolute defined for .mw-echo-ui-menuItemWidget-icon which is not being applied, because OOUI styles are more specific.
Change 400404 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Echo@master] mw.echo.ui.MenuItemWidget: Override OOUI styles harder
@matmarex awesome, thank you -- is this relatively new? The previous stylesheet already tried to override "specific" rules, it seems at some point the rules became even more specific...? (Sorry, I misread the old/new code, but I'm still curious about when this broke, if you have an idea?)
Change 400404 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] mw.echo.ui.MenuItemWidget: Override OOUI styles harder
@Mooeypoo New from rGOJU8e31b2f27342: Generalize icon and indicator positioning & visibility. It adds a bunch of highly specific rules :(
The issue seems to be fixed - checked in betalabs:
compare with the present enwiki (wmf.12)
