Page MenuHomePhabricator
Create Task
Maniphest T183454

Deprovision Diamond collectors no longer in use
Closed, ResolvedPublic
Actions

Description

With T177196: Port non-deprecated Diamond collectors to Prometheus we've deprecated several Diamond collectors now, we can thus proceed to deprovision / decom the ones that are no longer in use. Time wise this should happen in 10-12 weeks to give Prometheus enough time to collect data.

For hosts running only basic collectors (e.g. system stats already replaced by node-exporter) we should consider removing Diamond altogether.

Collectors to deprecate:

  • memcached modules/memcached/manifests/init.pp
  • nginx: modules/debug_proxy/manifests/init.pp modules/dynamicproxy/manifests/init.pp modules/profile/manifests/docker/registry.pp modules/puppetmaster/manifests/puppetdb.pp
  • ircdstats: modules/mw_rc_irc/manifests/ircserver.pp
  • nutcracker: modules/nutcracker/manifests/monitoring.pp
  • apachestatussimple: modules/phabricator/manifests/monitoring.pp
  • etherpad: modules/profile/manifests/etherpad.pp
  • kubernetes: modules/profile/manifests/kubernetes/master.pp
  • redis: modules/profile/manifests/redis/master.pp modules/profile/manifests/redis/multidc.ppmodules/profile/manifests/redis/slave.pp
  • udpcollector: modules/profile/manifests/statsd.pp
  • pybal: modules/pybal/manifests/monitoring.pp
  • rabbitmq: modules/rabbitmq/manifests/monitor.pp
  • openldap/corp: modules/role/manifests/openldap/corp.pp
  • openldap/labs:modules/role/manifests/openldap/labs.pp
  • ntpd: modules/ntp/manifests/daemon.pp
  • nfsdcollector: modules/labstore/manifests/monitoring/nfsd.pp
  • DirectorySize: modules/role/manifests/labs/nfs/secondary.pp

Diamond in Toolforge is tracked via T210991

Diamond in Cloud VPS is tracked via T210993

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move declaration of diamond package and config out of diamond classoperations/puppetproduction+11 -15
memcached, redis: remove diamondoperations/puppetproduction+4 -17
hiera: remove diamond from labweb roleoperations/puppetproduction+2 -0
Remove Diamond from further rolesoperations/puppetproduction+26 -2
Remove Diamond from further rolesoperations/puppetproduction+32 -0
Remove Diamond from ORES hostsoperations/puppetproduction+2 -0
Remove now obsolete Diamond collector and related conffileoperations/puppetproduction+0 -140
memcached: deprecate Diamond collectoroperations/puppetproduction+1 -0
hiera: remove diamond from thumbor roleoperations/puppetproduction+3 -0
memcached: remove diamond::collector resourceoperations/puppetproduction+0 -3
memcached: remove memcached diamond collectoroperations/puppetproduction+1 -3
remove diamond::collector reference from role::labs::nfs::secondaryoperations/puppetproduction+0 -3
Remove Diamond from DNS rolesoperations/puppetproduction+2 -0
remove directorysize diamond collectoroperations/puppetproduction+1 -3
Remove Diamond on maps serversoperations/puppetproduction+2 -0
Remove Redis collectoroperations/puppetproduction+0 -4
Absent Redis Diamond collector on mc* serversoperations/puppetproduction+1 -1
Absent NfsdCollector Diamond collectoroperations/puppetproduction+1 -193
Remove Diamond from redis::misc systemsoperations/puppetproduction+2 -8
Absent Redis Diamond collector on Redis mastersoperations/puppetproduction+1 -1
Remove Diamond on additional DB rolesoperations/puppetproduction+3 -0
Absent Redis Diamond collector on Redis slavesoperations/puppetproduction+1 -1
mw_rc_irc: remove diamond::collector resource and collector scriptoperations/puppetproduction+1 -56
Remove IRCDStats collectoroperations/puppetproduction+1 -56
Remove Diamond from DB rolesoperations/puppetproduction+14 -0
mw_rc_irc: ensure diamond::collector absentoperations/puppetproduction+1 -4
Remove Diamond from Ganeti hostsoperations/puppetproduction+1 -0
Remove Diamond from several analytics rolesoperations/puppetproduction+13 -1
Remove Diamond from restbase serversoperations/puppetproduction+2 -0
Disable Diamond on Graphite hostsoperations/puppetproduction+1 -0
nginx: use latest commitoperations/puppetproduction+1 -1
Remove ApacheStatusSimpleCollectoroperations/puppetproduction+0 -67
Remove PyBalStateCollectoroperations/puppetproduction+0 -69
Remove absented Diamond collector for NTPoperations/puppetproduction+0 -4
nginx: remove diamond::collector::nginx referenceoperations/puppet/nginxmaster+2 -1
Remove server-boardoperations/puppetproduction+0 -1 K
Disable Diamond on WDQS hostsoperations/puppetproduction+4 -0
Remove Diamond from openldap/corp serversoperations/puppetproduction+1 -4
Absent unused Diamond collector for ldap/corpoperations/puppetproduction+2 -5
role: add aggregations for TCP Fast Open to prometheus globaloperations/puppetproduction+8 -0
Remove Diamond from Swift backendsoperations/puppetproduction+1 -0
ntp: ensure absent ntpd diamond collectoroperations/puppetproduction+3 -1
diamond: remove diamond::collector::nginxoperations/puppetproduction+8 -32
grafana: deprecate Diamond metrics in swift dashboardoperations/puppetproduction+118 -42
Remove Diamond from Elastic hostsoperations/puppetproduction+2 -0
Remove Diamond from Kubernetes hostsoperations/puppetproduction+2 -0
hiera: diamond::remove on openstack control roleoperations/puppetproduction+4 -8
Remove Diamond on spare hostsoperations/puppetproduction+1 -0
Remove Diamond from cachesoperations/puppetproduction+5 -1
ntp: move diamond::collector to where it will only apply to ntp serversoperations/puppetproduction+7 -1
Remove Diamond from Matomooperations/puppetproduction+1 -0
diamond: ensure Nginx collector absentoperations/puppetproduction+1 -1
Remove Diamond from Parsoidoperations/puppetproduction+1 -0
Remove now obsolete Diamond collectoroperations/puppetproduction+0 -75
keyholder, diamond: remove nagios collector and diamondoperations/puppetproduction+1 -54
phabricator: remove diamond::collector and purge diamondoperations/puppetproduction+1 -5
hiera: remove diamond from kubernetes mastersoperations/puppetproduction+2 -5
kubernetes: remove kubernetes diamond collectoroperations/puppetproduction+1 -0
Absent Kubernetes diamond collectoroperations/puppetproduction+1 -0
phabricator: remove custom diamond::collectoroperations/puppetproduction+2 -1
diamond: remove nagios collectoroperations/puppetproduction+5 -15
Remove Diamond from LVSesoperations/puppetproduction+1 -0
Remove Diamond from LVSesoperations/puppetproduction+1 -0
Remove Pybal Diamond collectoroperations/puppetproduction+1 -0
hiera: remove diamond from mediawiki roleoperations/puppetproduction+6 -0
prometheus: add scrapes for apache on phabricator instancesoperations/puppetproduction+8 -0
shinken: Remove broken 'Keyholder status' checkoperations/puppetproduction+0 -7
hiera: remove diamond on deployment_server roleoperations/puppetproduction+1 -0
hiera: remove diamond on dumps roleoperations/puppetproduction+4 -0
hiera: remove diamond from scb roleoperations/puppetproduction+1 -0
prometheus: add collector.ntp.server option and enable on recursor nodesoperations/puppetproduction+5 -1
nutcracker: set diamond::remove on all roles containing nutcrackeroperations/puppetproduction+15 -5
nutcracker: remove diamond collector resourceoperations/puppetproduction+0 -5
Remove Diamond from Hadoop systemsoperations/puppetproduction+8 -0
Remove diamond on webserver_misc_static roleoperations/puppetproduction+1 -0
Cleanup systemd state on Diamond removaloperations/puppetproduction+9 -5
nutcracker: ensure absent nutcracker.pyoperations/puppetproduction+2 -1
hiera: enable ntp collector on role::recursoroperations/puppetproduction+3 -0
Disable Diamond on test roleoperations/puppetproduction+1 -0
Remove obsolete Diamond collectorsoperations/puppetproduction+0 -132
Remove all absented Diamond collectorsoperations/puppetproduction+0 -102
Stop the diamond service when removing Diamondoperations/puppetproduction+5 -0
Remove now obsolete Diamond collectoroperations/puppetproduction+0 -264
profile, graphite: remove diamondoperations/puppetproduction+1 -2
Remove Diamond from openldap/labs hostsoperations/puppetproduction+1 -8
hiera: enable ntp collector on labcontrol to replace ntpd diamond collectoroperations/puppetproduction+4 -0
hiera: comment out diamond::removeoperations/puppetproduction+2 -2
ntp: remove diamond::collector in favor of prometheus-node-exporteroperations/puppetproduction+0 -2
openstack, rabbitmq: remove diamondoperations/puppetproduction+2 -21
standard: remove diamond::collector declaration from standard::ntp::timesyncdoperations/puppetproduction+0 -5
hiera: remove diamond from etherpadoperations/puppetproduction+1 -0
Allow removing Diamond graduallyoperations/puppetproduction+33 -16
statsite: deprecate Diamond udp collectoroperations/puppetproduction+3 -1
Deprecate Diamond tcpconnstate and nfconntrackcountoperations/puppetproduction+7 -0
Deprecate Diamond pdns collectorsoperations/puppetproduction+3 -2
elasticsearch: deprecate Diamond collectorsoperations/puppetproduction+3 -2
ores: deprecate Diamond redis collectoroperations/puppetproduction+1 -0
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedfgiunchediT205862 Expand modern metrics infrastructure coverage (2018-19 Q2 goal)
 ResolvedcolewhiteT183454 Deprovision Diamond collectors no longer in use
 DeclinedNoneT206327 Setup metrics monitoring for OpenLDAP/corp
 ResolvedfgiunchediT207041 Adapt Kafka dashboards to use metrics from prometheus-node-exporter
 DuplicateNoneT210991 Deprecate Diamond collectors in Tool Labs / Tool Forge
 ResolvedMoritzMuehlenhoffT210993 Deprecate Diamond collectors in Cloud VPS
 ResolvedMoritzMuehlenhoffT228238 Remove nfsiostat collector for diamond if possible, which may be broken on tools workers
 ResolvedtaaviT264920 Grafana "cloud-vps-project-board" needs to be migrated from Graphite to Prometheus
 ResolvedtaaviT266050 Build Prometheus service for use by all Cloud VPS projects and their instances
 Resolved• JHeddenT250206 Deploy a proof of concept prometheus server in cloudvps to replace shinken
 Resolved• JHeddenT250210 Request creation of metricsinfra VPS project
 Resolved• BstormT252260 Try out removing the nfs client probes from the node exporter on VMs
 Resolvedbd808T256134 wikistats.analytics.eqiad.wmflabs blocking Prometheus scraping from metricsinfra
 ResolvedAndrewT128615 Get rid of Toolforge home page check from shinken
 DeclinedNoneT128716 Make icinga-wm report Tools homepage check at #wikimedia-cloud, too
 Resolved• nskaggsT284973 Request increased quota for metricsinfra Cloud VPS project
 ResolvedtaaviT285055 Allow project members/admins to ack/silence alerts of that project
 ResolvedjbondT286716 Create solution for developer account authentication for services hosted in Cloud VPS
 ResolvedtaaviT286301 Scale up metricsinfra prometheus beyond one Prometheus instance (Thanos/Cortex/similar)
 ResolvedtaaviT286335 Split metricsinfra alertmanager to separate hosts from prometheus
 ResolvedtaaviT287148 Set up IRC relay for metricsinfra alerts
 ResolvedtaaviT310799 Upgrade metricsinfra prometheus to bullseye
 ResolveddcaroT310802 Request increased quota for metricsinfra Cloud VPS project
 ResolvedAndrewT288108 Figure out how to deal with security groups when rolling out metricsinfra scraping
 ResolvedcolewhiteT211094 Port DirectorySize diamond collector to a Prometheus exporter

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Nov 16 2018, 5:10 PM

Change 473302 merged by Cwhite:
[operations/puppet@production] diamond: remove diamond::collector::nginx

https://gerrit.wikimedia.org/r/473302

gerritbot added a comment.Nov 16 2018, 6:34 PM

Change 474309 had a related patch set uploaded (by Cwhite; owner: Cwhite):
[operations/puppet/nginx@master] nginx: remove diamond::collector::nginx reference

https://gerrit.wikimedia.org/r/474309

gerritbot added a comment.Nov 16 2018, 8:23 PM

Change 474321 had a related patch set uploaded (by Cwhite; owner: Cwhite):
[operations/puppet@production] role: add aggregations for TCP Fast Open to prometheus global

https://gerrit.wikimedia.org/r/474321

gerritbot added a comment.Nov 16 2018, 8:53 PM

Change 473295 merged by Cwhite:
[operations/puppet@production] ntp: ensure absent ntpd diamond collector

https://gerrit.wikimedia.org/r/473295

gerritbot added a comment.Nov 19 2018, 7:48 AM

Change 474280 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond from Swift backends

https://gerrit.wikimedia.org/r/474280

gerritbot added a comment.Nov 19 2018, 2:33 PM

Change 474695 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Disable Diamond on WDQS hosts

https://gerrit.wikimedia.org/r/474695

gerritbot added a comment.Nov 19 2018, 2:44 PM

Change 474698 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Absent unused Diamond collector for ldap/corp

https://gerrit.wikimedia.org/r/474698

gerritbot added a comment.Nov 19 2018, 2:44 PM

Change 474699 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Diamond from openldap/corp servers

https://gerrit.wikimedia.org/r/474699

gerritbot added a comment.Nov 19 2018, 4:40 PM

Change 474321 merged by Cwhite:
[operations/puppet@production] role: add aggregations for TCP Fast Open to prometheus global

https://gerrit.wikimedia.org/r/474321

gerritbot added a comment.Nov 20 2018, 8:19 AM

Change 474698 merged by Muehlenhoff:
[operations/puppet@production] Absent unused Diamond collector for ldap/corp

https://gerrit.wikimedia.org/r/474698

gerritbot added a comment.Nov 20 2018, 8:27 AM

Change 474699 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond from openldap/corp servers

https://gerrit.wikimedia.org/r/474699

gerritbot added a comment.Nov 20 2018, 8:32 AM

Change 474695 merged by Muehlenhoff:
[operations/puppet@production] Disable Diamond on WDQS hosts

https://gerrit.wikimedia.org/r/474695

MoritzMuehlenhoff updated the task description. (Show Details)Nov 20 2018, 8:48 AM
gerritbot added a comment.Nov 20 2018, 9:32 AM

Change 474855 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove server-board

https://gerrit.wikimedia.org/r/474855

gerritbot added a comment.Nov 20 2018, 9:46 AM

Change 474864 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove ApacheStatusSimpleCollector

https://gerrit.wikimedia.org/r/474864

gerritbot added a comment.Nov 20 2018, 9:58 AM

Change 474865 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove PyBalStateCollector

https://gerrit.wikimedia.org/r/474865

gerritbot added a comment.Nov 20 2018, 11:40 AM

Change 474887 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove absented Diamond collector for NTP

https://gerrit.wikimedia.org/r/474887

gerritbot added a comment.Nov 20 2018, 2:57 PM

Change 474855 merged by Muehlenhoff:
[operations/puppet@production] Remove server-board

https://gerrit.wikimedia.org/r/474855

gerritbot added a comment.Nov 20 2018, 3:13 PM

Change 474922 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Disable Diamond on Graphite hosts

https://gerrit.wikimedia.org/r/474922

gerritbot added a comment.Nov 20 2018, 3:49 PM

Change 474930 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Diamond from restbase servers

https://gerrit.wikimedia.org/r/474930

gerritbot added a comment.Nov 20 2018, 4:12 PM

Change 474309 merged by jenkins-bot:
[operations/puppet/nginx@master] nginx: remove diamond::collector::nginx reference

https://gerrit.wikimedia.org/r/474309

gerritbot added a comment.Nov 20 2018, 4:18 PM

Change 474940 had a related patch set uploaded (by Cwhite; owner: Cwhite):
[operations/puppet@production] nginx: use latest commit

https://gerrit.wikimedia.org/r/474940

gerritbot added a comment.Nov 20 2018, 4:25 PM

Change 474887 merged by Cwhite:
[operations/puppet@production] Remove absented Diamond collector for NTP

https://gerrit.wikimedia.org/r/474887

gerritbot added a comment.Nov 20 2018, 6:39 PM

Change 474865 merged by Muehlenhoff:
[operations/puppet@production] Remove PyBalStateCollector

https://gerrit.wikimedia.org/r/474865

gerritbot added a comment.Nov 20 2018, 6:46 PM

Change 474864 merged by Muehlenhoff:
[operations/puppet@production] Remove ApacheStatusSimpleCollector

https://gerrit.wikimedia.org/r/474864

gerritbot added a comment.Nov 20 2018, 10:43 PM

Change 475009 had a related patch set uploaded (by Cwhite; owner: Cwhite):
[operations/puppet@production] mw_rc_irc: ensure diamond::collector absent

https://gerrit.wikimedia.org/r/475009

gerritbot added a comment.Nov 20 2018, 10:44 PM

Change 475010 had a related patch set uploaded (by Cwhite; owner: Cwhite):
[operations/puppet@production] mw_rc_irc: remove diamond::collector resource

https://gerrit.wikimedia.org/r/475010

colewhite updated the task description. (Show Details)Nov 20 2018, 10:48 PM
gerritbot added a comment.Nov 21 2018, 4:17 PM

Change 474940 merged by Cwhite:
[operations/puppet@production] nginx: use latest commit

https://gerrit.wikimedia.org/r/474940

colewhite updated the task description. (Show Details)Nov 21 2018, 4:20 PM
gerritbot added a comment.Nov 22 2018, 7:57 AM

Change 474922 merged by Muehlenhoff:
[operations/puppet@production] Disable Diamond on Graphite hosts

https://gerrit.wikimedia.org/r/474922

gerritbot added a comment.Nov 22 2018, 8:04 AM

Change 474930 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond from restbase servers

https://gerrit.wikimedia.org/r/474930

gerritbot added a comment.Nov 23 2018, 8:43 AM

Change 475444 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Diamond from several analytics roles

https://gerrit.wikimedia.org/r/475444

gerritbot added a comment.Nov 23 2018, 9:00 AM

Change 475444 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond from several analytics roles

https://gerrit.wikimedia.org/r/475444

gerritbot added a comment.Nov 23 2018, 12:17 PM

Change 475456 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Diamond from Ganeti hosts

https://gerrit.wikimedia.org/r/475456

gerritbot added a comment.Nov 26 2018, 8:57 AM

Change 475456 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond from Ganeti hosts

https://gerrit.wikimedia.org/r/475456

Krinkle unsubscribed.Nov 26 2018, 6:08 PM
gerritbot added a comment.Nov 26 2018, 11:27 PM

Change 475009 merged by Cwhite:
[operations/puppet@production] mw_rc_irc: ensure diamond::collector absent

https://gerrit.wikimedia.org/r/475009

gerritbot added a comment.Nov 27 2018, 8:08 AM

Change 475957 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove IRCDStats collector

https://gerrit.wikimedia.org/r/475957

gerritbot added a comment.Nov 27 2018, 8:52 AM

Change 475967 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Absent Redis Diamond collector on Redis slaves

https://gerrit.wikimedia.org/r/475967

gerritbot added a comment.Nov 27 2018, 8:59 AM

Change 475969 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Absent Redis Diamond collector on Redis masters

https://gerrit.wikimedia.org/r/475969

gerritbot added a comment.Nov 27 2018, 10:57 AM

Change 467264 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond from DB roles

https://gerrit.wikimedia.org/r/467264

gerritbot added a comment.Nov 27 2018, 12:42 PM

Change 475957 merged by Muehlenhoff:
[operations/puppet@production] Remove IRCDStats collector

https://gerrit.wikimedia.org/r/475957

MoritzMuehlenhoff updated the task description. (Show Details)Nov 27 2018, 12:45 PM
gerritbot added a comment.Nov 27 2018, 3:56 PM

Change 475010 abandoned by Cwhite:
mw_rc_irc: remove diamond::collector resource and collector script

Reason:
Removed in I44ea7b94ab1eab45a923917dd6f0c5b6ae629c5c

https://gerrit.wikimedia.org/r/475010

gerritbot added a comment.Nov 27 2018, 6:02 PM

Change 476001 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Diamond on additional DB roles

https://gerrit.wikimedia.org/r/476001

gerritbot added a comment.Nov 28 2018, 7:59 AM

Change 475967 merged by Muehlenhoff:
[operations/puppet@production] Absent Redis Diamond collector on Redis slaves

https://gerrit.wikimedia.org/r/475967

gerritbot added a comment.Nov 28 2018, 8:05 AM

Change 476001 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond on additional DB roles

https://gerrit.wikimedia.org/r/476001

gerritbot added a comment.Nov 28 2018, 9:18 AM

Change 475969 merged by Muehlenhoff:
[operations/puppet@production] Absent Redis Diamond collector on Redis masters

https://gerrit.wikimedia.org/r/475969

gerritbot added a comment.Nov 28 2018, 10:08 AM

Change 476226 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Diamond from redis::misc systems

https://gerrit.wikimedia.org/r/476226

gerritbot added a comment.Nov 29 2018, 8:14 AM

Change 476226 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond from redis::misc systems

https://gerrit.wikimedia.org/r/476226

• GTirloni mentioned this in T210750: Track NFS statistics through Prometheus.Nov 29 2018, 4:40 PM
gerritbot added a comment.Nov 29 2018, 7:41 PM

Change 476606 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Absent NfsdCollector Diamond collector

https://gerrit.wikimedia.org/r/476606

gerritbot added a comment.Nov 29 2018, 7:45 PM

Change 476606 merged by GTirloni:
[operations/puppet@production] Absent NfsdCollector Diamond collector

https://gerrit.wikimedia.org/r/476606

• GTirloni updated the task description. (Show Details)Nov 29 2018, 7:54 PM
gerritbot added a comment.Nov 30 2018, 4:22 PM

Change 476883 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Absent Redis Diamond collector on mc* servers

https://gerrit.wikimedia.org/r/476883

gerritbot added a comment.Dec 3 2018, 8:36 AM

Change 476883 merged by Muehlenhoff:
[operations/puppet@production] Absent Redis Diamond collector on mc* servers

https://gerrit.wikimedia.org/r/476883

MoritzMuehlenhoff updated the task description. (Show Details)Dec 3 2018, 10:05 AM
MoritzMuehlenhoff updated the task description. (Show Details)
MoritzMuehlenhoff updated the task description. (Show Details)Dec 3 2018, 10:08 AM
gerritbot added a comment.Dec 3 2018, 10:16 AM

Change 477231 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Redis collector

https://gerrit.wikimedia.org/r/477231

gerritbot added a comment.Dec 3 2018, 11:06 AM

Change 477231 merged by Muehlenhoff:
[operations/puppet@production] Remove Redis collector

https://gerrit.wikimedia.org/r/477231

Krinkle subscribed.Dec 4 2018, 2:41 PM
In T183454#4746376, @MoritzMuehlenhoff wrote:

@Krinkle You've edited https://grafana.wikimedia.org/dashboard/db/cluster-board-graphite ...

I've deleted the dashboard now. It was created this during an incident investigation and hasn't been used since afaik.

gerritbot added a comment.Dec 5 2018, 10:23 AM

Change 477748 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Diamond on maps servers

https://gerrit.wikimedia.org/r/477748

gerritbot added a comment.Dec 6 2018, 8:32 AM

Change 477748 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond on maps servers

https://gerrit.wikimedia.org/r/477748

gerritbot added a comment.Dec 6 2018, 2:13 PM

Change 478016 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Diamond from DNS roles

https://gerrit.wikimedia.org/r/478016

colewhite closed subtask T211094: Port DirectorySize diamond collector to a Prometheus exporter as Resolved.Dec 7 2018, 4:47 PM
gerritbot added a comment.Dec 7 2018, 11:53 PM

Change 478368 had a related patch set uploaded (by Cwhite; owner: Cwhite):
[operations/puppet@production] remove directorysize diamond collector

https://gerrit.wikimedia.org/r/478368

gerritbot added a comment.Dec 7 2018, 11:58 PM

Change 478371 had a related patch set uploaded (by Cwhite; owner: Cwhite):
[operations/puppet@production] remove diamond::collector reference from role::labs::nfs::secondary

https://gerrit.wikimedia.org/r/478371

gerritbot added a comment.Dec 8 2018, 11:16 AM

Change 478368 merged by GTirloni:
[operations/puppet@production] remove directorysize diamond collector

https://gerrit.wikimedia.org/r/478368

gerritbot added a comment.Dec 10 2018, 12:46 PM

Change 478016 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond from DNS roles

https://gerrit.wikimedia.org/r/478016

colewhite updated the task description. (Show Details)Dec 10 2018, 4:20 PM
gerritbot added a comment.Dec 10 2018, 4:51 PM

Change 478371 merged by GTirloni:
[operations/puppet@production] remove diamond::collector reference from role::labs::nfs::secondary

https://gerrit.wikimedia.org/r/478371

gerritbot added a comment.Dec 11 2018, 12:08 AM

Change 469250 merged by Cwhite:
[operations/puppet@production] memcached: remove memcached diamond collector

https://gerrit.wikimedia.org/r/469250

gerritbot added a comment.Dec 11 2018, 7:25 PM

Change 469258 merged by Cwhite:
[operations/puppet@production] memcached: remove diamond::collector resource

https://gerrit.wikimedia.org/r/469258

gerritbot added a comment.Dec 11 2018, 7:29 PM

Change 466907 merged by Cwhite:
[operations/puppet@production] hiera: remove diamond from thumbor role

https://gerrit.wikimedia.org/r/466907

gerritbot added a comment.Dec 11 2018, 7:32 PM

Change 429221 abandoned by Cwhite:
memcached: deprecate Diamond collector

Reason:
Covered by I4506039ff403bce1c5fc5b2093861a937d84e31b

https://gerrit.wikimedia.org/r/429221

colewhite updated the task description. (Show Details)Dec 11 2018, 7:33 PM
gerritbot added a comment.Dec 12 2018, 8:05 AM

Change 479169 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove now obsolete Diamond collector and related conffiles

https://gerrit.wikimedia.org/r/479169

gerritbot added a comment.Dec 12 2018, 11:55 AM

Change 479189 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Diamond from ORES hosts

https://gerrit.wikimedia.org/r/479189

gerritbot added a comment.Dec 12 2018, 6:47 PM

Change 479169 merged by Muehlenhoff:
[operations/puppet@production] Remove now obsolete Diamond collector and related conffile

https://gerrit.wikimedia.org/r/479169

gerritbot added a comment.Dec 13 2018, 7:44 AM

Change 479189 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond from ORES hosts

https://gerrit.wikimedia.org/r/479189

gerritbot added a comment.Dec 13 2018, 2:32 PM

Change 479446 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Diamond from further roles

https://gerrit.wikimedia.org/r/479446

gerritbot added a comment.Dec 13 2018, 7:05 PM

Change 479446 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond from further roles

https://gerrit.wikimedia.org/r/479446

gerritbot added a comment.Dec 17 2018, 9:06 AM

Change 480032 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Remove Diamond from further roles

https://gerrit.wikimedia.org/r/480032

gerritbot added a comment.Dec 18 2018, 9:09 AM

Change 480032 merged by Muehlenhoff:
[operations/puppet@production] Remove Diamond from further roles

https://gerrit.wikimedia.org/r/480032

MoritzMuehlenhoff closed this task as Resolved.Dec 18 2018, 4:18 PM
MoritzMuehlenhoff mentioned this in T212231: Remove Diamond from production.

This is done (and the task is getting too big as well), I created T212231 for some followup work.

gerritbot added a comment.Dec 18 2018, 10:25 PM

Change 466908 merged by Cwhite:
[operations/puppet@production] hiera: remove diamond from labweb role

https://gerrit.wikimedia.org/r/466908

gerritbot added a comment.Dec 18 2018, 10:28 PM

Change 464366 abandoned by Cwhite:
memcached, redis: remove diamond

Reason:
no longer needed

https://gerrit.wikimedia.org/r/464366

fgiunchedi closed subtask T207041: Adapt Kafka dashboards to use metrics from prometheus-node-exporter as Resolved.Jan 16 2019, 2:20 PM
MoritzMuehlenhoff closed subtask T206327: Setup metrics monitoring for OpenLDAP/corp as Declined.Jul 20 2020, 1:23 PM
Dzahn changed the status of subtask T210993: Deprecate Diamond collectors in Cloud VPS from Open to Stalled.Nov 17 2020, 1:10 AM
MoritzMuehlenhoff closed subtask T210993: Deprecate Diamond collectors in Cloud VPS as Resolved.Jun 24 2022, 9:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits