Page MenuHomePhabricator
Create Task
Maniphest T183477

Amazon errors showing up as [Object object]
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

We're not properly serializing errors when we set the API response, so they are totally unhelpful.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Properly serialize Amazon error messagesmediawiki/extensions/DonationInterfacemaster+42 -5
Customize query in gerrit

Event Timeline

Ejegg created this task.Dec 21 2017, 4:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2017, 4:45 PM
Ejegg added a comment.Dec 21 2017, 4:46 PM

FR-tech: to reproduce this error locally, try uncommenting the 'seller authorization note' on line 318 of the amazon adapter.

gerritbot subscribed.Dec 21 2017, 4:47 PM

Change 399659 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Properly serialize Amazon error messages

https://gerrit.wikimedia.org/r/399659

gerritbot added a project: Patch-For-Review.Dec 21 2017, 4:47 PM
Ejegg claimed this task.Dec 22 2017, 5:26 PM
Ejegg triaged this task as High priority.
Ejegg set the point value for this task to 2.
Ejegg moved this task from Triage to Completed in Q2 2017-18 on the Fundraising-Backlog board.
Ejegg added a project: Fundraising Sprint Winter Wanderland.
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Winter Wanderland board.
gerritbot added a comment.Dec 22 2017, 7:20 PM

Change 399659 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Properly serialize Amazon error messages

https://gerrit.wikimedia.org/r/399659

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 22 2017, 8:00 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Winter Wanderland board.Dec 22 2017, 8:09 PM
• DStrine moved this task from Completed in Q2 2017-18 to Completed in Q3 2017-18 on the Fundraising-Backlog board.Jan 2 2018, 6:11 PM
• DStrine added a project: Fundraising Sprint Asymmetrical Earth Theory.Jan 2 2018, 9:18 PM
Ejegg moved this task from Backlog to Done on the Fundraising Sprint Asymmetrical Earth Theory board.Jan 4 2018, 4:03 PM
Ejegg closed this task as Resolved.Jan 16 2018, 9:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits