Page MenuHomePhabricator

Fix difference in displayed donation amount when passing by query string
Closed, ResolvedPublic3 Estimated Story Points

Description

In some (rare) cases, there is a difference between the amount passed in the query string and the amount displayed in the donation form. This does neither depend on a specific banner nor on the skin used for displaying the form.

This also happens when POSTing from the donation form, which results in a lower amount stored into the database and displayed on the confirmation page.

Examples:
https://spenden.wikimedia.de/donation/new?skin=10h16&amountGiven=8.70&zahlweise=BEZ&periode=0
https://spenden.wikimedia.de/donation/new?skin=cat17&amountGiven=9.20

AC:

  • The page displays the passed amount exactly as it was passed with the query string
  • There is no difference between the given amount and the amount stored in the database

Event Timeline

kai.nissen renamed this task from BUG: when donating with current redesign, slightly wrong amount is being transfered/or shown to Fix difference in displayed donation amount when passing by query string.Mar 1 2018, 4:44 PM
kai.nissen updated the task description. (Show Details)
kai.nissen set the point value for this task to 3.
kai.nissen moved this task from Backlog to Sprint ready on the WMDE-Fundraising-Tech board.

Reworked Pablos example test case to test it also in the FundraisingFrontend context.

Deployed to test and prod.

@kai.nissen Since I've deployed now, please confirm done status.