Page MenuHomePhabricator
Create Task
Maniphest T183495

[BUG] [REGRESSSION] Color of icons on reading list bottom sheet should be lighter
Closed, ResolvedPublic
Actions

Description

Steps to reproduce
  1. Go to a reading list which contains at least one saved article
  2. Tap on the overflow menu on a saved article
Expected

Bottom sheet appears with icons using the "Material theme Secondary (text and icons)" color, which is Black@54% in Light mode.

Reading list - bottom sheet.png (720×1,280 px, 325 KB)

Actual

Icons appears almost black in light mode.

image.png (1,080×1,920 px, 351 KB)

Occurring on

Nexus 5 (6.0.1)
Wikipedia v2.7.222-alpha-2017-12-19

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix: Make the color of icons on reading list bottom sheet lighterapps/android/wikipediamaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

RHo created this task.Dec 21 2017, 8:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2017, 8:04 PM
cooltey claimed this task.Dec 21 2017, 11:37 PM
gerritbot subscribed.Dec 21 2017, 11:39 PM

Change 399758 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Make the color of icons on reading list bottom sheet lighter

https://gerrit.wikimedia.org/r/399758

gerritbot added a project: Patch-For-Review.Dec 21 2017, 11:39 PM
cooltey edited projects, added: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape); removed: Wikipedia-Android-App-Backlog.Dec 21 2017, 11:39 PM
Restricted Application edited projects, added: Wikipedia-Android-App-Backlog; removed: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape). · View Herald TranscriptDec 21 2017, 11:39 PM
cooltey edited projects, added: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape); removed: Wikipedia-Android-App-Backlog, Android-app-Bugs.Dec 21 2017, 11:39 PM
cooltey moved this task from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape) board.
RHo mentioned this in T180391: Enable secondary actions on articles shown within On this day.Dec 26 2017, 9:00 PM
gerritbot added a comment.Jan 2 2018, 3:28 PM

Change 399758 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Make the color of icons on reading list bottom sheet lighter

https://gerrit.wikimedia.org/r/399758

Dbrant moved this task from Code Review to Design Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape) board.Jan 2 2018, 4:01 PM
RHo moved this task from Design Signoff to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape) board.Jan 18 2018, 12:37 PM

LGTM on Moto X 5.1, Wikipedia 2.7.224-alpha-2018-01-17

image.png (720×1,280 px, 149 KB)

ABorbaWMF moved this task from QA Signoff to Ready for Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape) board.Jan 29 2018, 9:05 PM
ABorbaWMF subscribed.

Appears to be fixed on my devices on v2.7.224-alpha-2018-01-26

Dbrant moved this task from Ready for Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape) board.Feb 1 2018, 6:28 PM
Dbrant closed this task as Resolved.Feb 1 2018, 6:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits