EventLogging has invalid @covers tags
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Dec 22 2017, 7:45 AM

Description

08:02:51 1) JsonSchemaTest::testValidCovers
08:02:51 Failed asserting that two strings are equal.
08:02:51 --- Expected
08:02:51 +++ Actual
08:02:52 @@ @@
08:02:52 -''
08:02:52 +'JsonSchemaTest::testInvalidJson: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +JsonSchemaTest::testInvalidJsonSchema: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +JsonSchemaTest::testValidJsonSchema: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +JsonSchemaTest::testPreSaveTransform: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +JsonSchemaTest::testGetHighlightHtml: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +JsonSchemaTest::testValidCovers: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +'
08:02:52 
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiCoversValidator.php:48
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/maintenance/doMaintenance.php:94
08:02:52 
08:02:52 2) SerializeEventTest::testValidCovers
08:02:52 Failed asserting that two strings are equal.
08:02:52 --- Expected
08:02:52 +++ Actual
08:02:52 @@ @@
08:02:52 -''
08:02:52 +'SerializeEventTest::testSerializeEventEmptyEvent: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +SerializeEventTest::testSerializeEventHappyCase: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +SerializeEventTest::testValidCovers: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +'
08:02:52 
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiCoversValidator.php:48
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/maintenance/doMaintenance.php:94
08:02:52 
08:02:52 3) ValidateSchemaTest::testValidCovers
08:02:52 Failed asserting that two strings are equal.
08:02:52 --- Expected
08:02:52 +++ Actual
08:02:52 @@ @@
08:02:52 -''
08:02:52 +'ValidateSchemaTest::testValidJson: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +ValidateSchemaTest::testValidEvent: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +ValidateSchemaTest::testInvalidEvent: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +ValidateSchemaTest::testEventNonMandatoryProperties: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +ValidateSchemaTest::testEmptyEventForSchemaWithOptionalOnlyPropertiesIsValid: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +ValidateSchemaTest::testValidCovers: Trying to @cover or @use not existing class or interface "JsonSchema".
08:02:52 +'
08:02:52 
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiCoversValidator.php:48
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/maintenance/doMaintenance.php:94

There isn't a JsonSchema class.

Details

	Subject	Repo	Branch	Lines +/-
	Remove/fix bogus @covers annotations	mediawiki/extensions/EventLogging	master	+2 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Legoktm	T171899 Validate @covers tags during normal test runs
		Resolved		MaxSem	T183528 EventLogging has invalid @covers tags

Event Timeline

Legoktm triaged this task as Lowest priority.Dec 22 2017, 7:45 AM

Legoktm created this task.

Restricted Application added a project: Analytics. · View Herald TranscriptDec 22 2017, 7:45 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Legoktm updated the task description. (Show Details)Dec 22 2017, 8:05 AM

There is a php file named "JsonSchema.php" with multi classes. Would adding ".php" fix this? (https://phabricator.wikimedia.org/diffusion/EEVL/browse/master/tests/phpunit/JsonSchemaTest.php)

Or file names are a bad idea? See https://gerrit.wikimedia.org/r/#/c/395978/1/tests/phpunit/includes/ServiceWiringTest.php for another discussion

https://phpunit.de/manual/4.8/en/appendixes.annotations.html#appendixes.annotations.covers.tables.annotations doesn't mention anything about being able to cover whole files?

It is not used often: https://codesearch.wmflabs.org/search/?q=@covers.*\.php&i=nope&files=&repos=

extensions / Cognate

tests/phpunit/ServiceWiringTest.php

11
12/**
13 * @covers ServiceWiring.php
14 *
15 * @license GNU GPL v2+

extensions / ORES

tests/phpunit/includes/ServiceWiringTest.php

8
9/**
10 * @covers ORES\ServiceWiring.php
11 *
12 * @license GNU GPL v2+

extensions / WikibaseMediaInfo

tests/phpunit/mediawiki/EntityTypesTest.php

19
20/**
21 * @covers WikibaseMediaInfo.entitytypes.php
22 *
23 * @group WikibaseMediaInfo

Change 399950 had a related patch set uploaded (by Legoktm; owner: MaxSem):
[mediawiki/extensions/EventLogging@master] Remove/fix bogus @covers annotations

https://gerrit.wikimedia.org/r/399950

gerritbot added a project: Patch-For-Review.Dec 22 2017, 10:06 PM

Change 399950 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Remove/fix bogus @covers annotations

https://gerrit.wikimedia.org/r/399950

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 22 2017, 11:00 PM