Page MenuHomePhabricator

Wikibase has invalid @covers tags
Closed, ResolvedPublic

Description

08:02:52 6) Wikibase\Lib\Tests\Store\TypeDispatchingEntityRevisionLookupTest::testValidCovers
08:02:52 Failed asserting that two strings are equal.
08:02:52 --- Expected
08:02:52 +++ Actual
08:02:52 @@ @@
08:02:52 -''
08:02:52 +'Wikibase\Lib\Tests\Store\TypeDispatchingEntityRevisionLookupTest::testGivenInvalidCallback_getEntityRevisionFails: Trying to @cover or @use not existing method "TypeDispatchingEntityRevisionLookup::getLookup".
08:02:52 +'
08:02:52 
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiCoversValidator.php:48
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/maintenance/doMaintenance.php:94
08:02:52 
08:02:52 7) Wikibase\Lib\Tests\Store\TypeDispatchingEntityStoreTest::testValidCovers
08:02:52 Failed asserting that two strings are equal.
08:02:52 --- Expected
08:02:52 +++ Actual
08:02:52 @@ @@
08:02:52 -''
08:02:52 +'Wikibase\Lib\Tests\Store\TypeDispatchingEntityStoreTest::testGivenInvalidCallback_saveEntityFails: Trying to @cover or @use not existing method "TypeDispatchingEntityStore::getStore".
08:02:52 +'
08:02:52 
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiCoversValidator.php:48
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/maintenance/doMaintenance.php:94
08:02:52 
08:02:52 8) Wikibase\Repo\Tests\Store\TypeDispatchingEntityTitleStoreLookupTest::testValidCovers
08:02:52 Failed asserting that two strings are equal.
08:02:52 --- Expected
08:02:52 +++ Actual
08:02:52 @@ @@
08:02:52 -''
08:02:52 +'Wikibase\Repo\Tests\Store\TypeDispatchingEntityTitleStoreLookupTest::testGivenInvalidCallback_getTitleForIdFails: Trying to @cover or @use not existing method "TypeDispatchingEntityTitleStoreLookup::getLookup".
08:02:52 +'
08:02:52 
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiCoversValidator.php:48
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
08:02:52 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/maintenance/doMaintenance.php:94

Related Objects

Event Timeline

Legoktm triaged this task as Lowest priority.Dec 22 2017, 7:50 AM
Legoktm created this task.
Restricted Application added a project: Wikidata. · View Herald TranscriptDec 22 2017, 7:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Legoktm updated the task description. (Show Details)Dec 22 2017, 8:04 AM

Change 399971 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Wikibase@master] Fix invalid @covers tags

https://gerrit.wikimedia.org/r/399971

Change 399971 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix invalid @covers tags

https://gerrit.wikimedia.org/r/399971

Umherirrender closed this task as Resolved.Dec 23 2017, 10:02 AM
Umherirrender assigned this task to Legoktm.