| He7d3r | |
| Dec 22 2017, 11:00 AM |
| F17290615: image.png | |
| Apr 24 2018, 7:58 PM |
| F16813242: Screen Shot 2018-04-07 at 7.49.18 PM.png | |
| Apr 8 2018, 2:58 AM |
| F16804291: screenshot.png | |
| Apr 7 2018, 8:34 PM |
| F16372721: Screen Shot 2018-03-28 at 12.35.22 PM.png | |
| Mar 28 2018, 7:40 PM |
| F13391193: Screen Shot 2018-02-09 at 9.58.06 AM.png | |
| Feb 9 2018, 5:59 PM |
| F13391026: Screen Shot 2018-02-09 at 9.51.07 AM.png | |
| Feb 9 2018, 5:59 PM |
| F13338993: Screen Shot 2018-02-08 at 5.39.15 PM.png | |
| Feb 9 2018, 1:41 AM |
| F13338979: Screen Shot 2018-02-08 at 5.31.06 PM.png | |
| Feb 9 2018, 1:41 AM |
When I access
https://pt.wikipedia.org/wiki/Special:Preferences?useskin=vector
(or https://pt.wikipedia.org/wiki/Special:Preferences?useskin=monobook)
using Firefox 58.0.1 (64-bit) on Ubuntu 17.10, the badge overlaps with the "Talk" link at the top of the page.
For example, this is what I see using the Vector skin (and pt as the user language):
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/Echo | master | +1 -0 | Add extra margin for the badge when count is 99+ |
There were two phab task about the same issue: https://phabricator.wikimedia.org/T142454 and https://phabricator.wikimedia.org/T153976
@He7d3r I could not reproduce it locally. Could you provide the following details:
thanks!
Thanks @He7d3r for adding the details.
@SBisson - strangely, the issue is not present in betalabs (Portugese, FF58) if it's a real count:
But it's easily can be seen in betalabs or ptwiki (wmf.17, Chrome) with changing data-counter-textto 99+
<a href="/wiki/Special:Notifications" class="mw-echo-notifications-badge mw-echo-notification-badge-nojs" data-counter-num="4" data-counter-text="99+" title="Your notices">Notices (4)</a>
I do not have many notifications in production, so I cannot confirm the case when the real count is 99+.
Change 422434 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/extensions/Echo@master] Add extra margin for the badge when count is 99+
Change 422434 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Add extra margin for the badge when count is 99+
This is how it looks like on ptwiki now:
Re-opening the issue - the overlapping is still happening - not as much as it was initially reported, but it's still noticeable (wmf.28 Chrome 64 on Mac):
We’ve decided to leave this issue closed after all, as the behavior is relatively acceptable.
