We should have a test that attempts to compile mediawiki-vagrant puppet roles. rspec-puppet does magic on that front.
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | zeljkofilipin | T183456 Continuous integration for mediawiki-vagrant | |||
| Declined | None | T183570 Create a test suite that compiles mediawiki-vagrant puppet manifests | |||
| Resolved | hashar | T183575 Match puppet version in Gemfile and actual box |
Event Timeline
Comment Actions
Change 399834 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/vagrant@master] rspec-puppet for all the roles
Comment Actions
Change 399965 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/vagrant@stretch-migration] rspec-puppet for all the roles
Comment Actions
Change 400098 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/vagrant@stretch-migration] thumbor: nproc => $::processorcount
Comment Actions
https://gerrit.wikimedia.org/r/399965 more or less compiles the catalog for the initial provisioning (site.pp) and for each of the roles. There are a few roles that fail for different kind of reasons, some of them already got fixed! I guess after the holiday I will look at wrapping that in a Jenkins job one can manually trigger.
Comment Actions
Change 399834 abandoned by Hashar:
rspec-puppet for all the roles
Reason:
That is being done in the stretch-migration branch: https://gerrit.wikimedia.org/r/#/c/399965/
Comment Actions
Change 400098 merged by jenkins-bot:
[mediawiki/vagrant@stretch-migration] thumbor: nproc => $::processorcount
Comment Actions
Change 401545 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/vagrant@stretch-migration] Compile puppet catalogs in CI
Comment Actions
Change 399965 merged by jenkins-bot:
[mediawiki/vagrant@stretch-migration] rspec-puppet for all the roles
Comment Actions
I did most of the suite integration during my holidays. Bryan happily reviewed and merged the patches.
The steps for later:
- https://gerrit.wikimedia.org/r/#/c/401545/5 would cause CI to compile the base puppet catalog. Would surely help catch a few bad changes.
- for later, add a daily job that runs all the specs (eg :compile task with some Junit/Checkstyle report). That can be done later.
Comment Actions
Change 401545 merged by jenkins-bot:
[mediawiki/vagrant@stretch-migration] Compile the base puppet catalog on CI
Comment Actions
status update
We need a Jenkins job that compiles all the roles on a daily basis and notify somewhere. Not sure which mailing list to send the spam to though.