We should have a test that attempts to compile mediawiki-vagrant puppet roles. rspec-puppet does magic on that front.
|Declined||zeljkofilipin||T183456 Continuous integration for mediawiki-vagrant|
|Declined||None||T183570 Create a test suite that compiles mediawiki-vagrant puppet manifests|
|Resolved||hashar||T183575 Match puppet version in Gemfile and actual box|
https://gerrit.wikimedia.org/r/399965 more or less compiles the catalog for the initial provisioning (site.pp) and for each of the roles. There are a few roles that fail for different kind of reasons, some of them already got fixed! I guess after the holiday I will look at wrapping that in a Jenkins job one can manually trigger.
I did most of the suite integration during my holidays. Bryan happily reviewed and merged the patches.
The steps for later:
- https://gerrit.wikimedia.org/r/#/c/401545/5 would cause CI to compile the base puppet catalog. Would surely help catch a few bad changes.
- for later, add a daily job that runs all the specs (eg :compile task with some Junit/Checkstyle report). That can be done later.